From owner-svn-ports-all@freebsd.org Fri Feb 3 00:58:50 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B00ECCCFC2 for ; Fri, 3 Feb 2017 00:58:50 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E64C3169B for ; Fri, 3 Feb 2017 00:58:49 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: by mail-qt0-f196.google.com with SMTP id w20so1213914qtb.1 for ; Thu, 02 Feb 2017 16:58:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=c80qzWXuW+SHZxtYhPi7oE8jichDJA4LFIVSLLPK8u0=; b=HjD4ZT44/LsXvFiqDnm1OF0wz0VsX0hOvNSeroFVLU1Q9Bjb5tk2Jo1+yvQ+bsI8hY K3HTmugBSVouDGkdcewll8TW5KLBkrYWiUuaypJA6QRGB6PtUQq6mQRg8Clnfpg1AJTS rTqj7Xa7oVasn+YXmgQWPrz/IqLTDNsa9XaW7OOd1f/Ani5sQlflh/U+t0hS8uXI0klM 73KmkEIU+4M1zjvwKRA7BhBN2s0I77j1ckOTikLRedcxYTO4gR220CN+oW+FQUS8WV+O qfiaek/Pu4I2bEBltdUZzKP9zyj/xm5NuDkxQi91/VH3noqZnsZG59xwEogWYTu0HKuW xW8w== X-Gm-Message-State: AIkVDXIDKA6OX2uNvjrWYYCjEFsi5xv8YDjL1H1iKOWSp/2KUHCpOM+K4xPsRyybw4sagw== X-Received: by 10.55.81.194 with SMTP id f185mr10985060qkb.153.1486083095892; Thu, 02 Feb 2017 16:51:35 -0800 (PST) Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-142068129158.dhcp-dynamic.FibreOp.ns.bellaliant.net. [142.68.129.158]) by smtp.gmail.com with ESMTPSA id a54sm22904399qta.48.2017.02.02.16.51.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Feb 2017 16:51:35 -0800 (PST) From: Joseph Mingrone To: ashish@FreeBSD.org (Ashish SHUKLA) Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r433143 - head/editors/emacs-devel References: <201702021252.v12CqTos081552@repo.freebsd.org> <86y3xot8mo.fsf@FreeBSD.org> Date: Thu, 02 Feb 2017 20:51:33 -0400 In-Reply-To: <86y3xot8mo.fsf@FreeBSD.org> (Ashish SHUKLA's message of "Fri, 03 Feb 2017 06:04:23 +0530") Message-ID: <861svg5c6i.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 00:58:50 -0000 --=-=-= Content-Type: text/plain ashish@FreeBSD.org (Ashish SHUKLA) writes: > On Thu, 2 Feb 2017 12:52:29 +0000 (UTC), Joseph Mingrone said: > | Author: jrm > | Date: Thu Feb 2 12:52:29 2017 > | New Revision: 433143 > | URL: https://svnweb.freebsd.org/changeset/ports/433143 > | Log: > | editors/emacs-devel: Update to latest commit on master branch > | Approved by: ashish (maintainer, implicit), swills (mentor, implicit) > Hi Joseph, > Thanks for the update, although I didn't approve this diff. > The implicit approval you sought[1] was for PORTREVISION bump, and this commit > is not that. > References: > [1] https://reviews.freebsd.org/D9287#192339 > Thanks! Hello Ashish, My apologies! This indeed wasn't what we had agreed upon. I somehow had it in my mind that the implicit approval was for updating to a newer upstream commit. Hopefully this will teach me not to do such things in a rush with many other things going on at the same time. This commit was in the spirit on what I had in mind. That is, get newer code out regularly in the -devel port, so users can test early and often. Would such a commit, that only modifies the GH_TAGNAME, EMACS_REV, and the distfile also be acceptable for implicit approval? Again, sorry for breaking our agreement. It was due to careless and not intentional. Joseph --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJYk9QVXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1NUIwOTNBNzI2QzM4ODU1NzEyMkJBRDUz NkE0MEM4M0IwRDZFRjlFAAoJEDakDIOw1u+e9c0P/AhjGgVAyx8kczjJhGDl8wSr VJ95zpuYfAxlvix55yWHm93S2SgSSZX7ICX6yDvp33tW/fVl5/nSMWBTT392lfT0 encFo8ZbkmKF6iCOKjz1kglRLZ25HdqIZ03M86QWmGwL4Kw+xTXbEXMlAwi1wTCx 8DIZO5bzRmJiKpLhsEquUuF90q2YFSsIBB1F1ot54JrCdAZG42rsQEqGsHU2Qblw kITyc6Oopk2KWR1h1zXFS6TPMJ4K7qX1Peg7VzlmxV8UsW1MLkz4YhV1oIs8QBDq L0IfQwxZqaDNmL2XHmncrlD9cD9h0+p9051wjKX9Tpra1mOBqQXXxcY51coUemKG 0w68jhQwN7xTDtB0SjMIASOvPTBhu3nCDYRH1H5Jrad0UdQl1VWdhT5ygReQWgCn gvytLwh5AxR5adIytwV4brEHKM82ywwRHySQSHEDcK2SzUP/kHFoEUtKN4RCh12S gudjW+SObCEXXT5LzApbDDHSu898HyDrCbwtch+eQzhgkneioJC4yV07A5/e91+5 cMIvV01B781JoJ/MDV5SnRYfp5NQpn6v4B/aliLFLOpUd2H2YsFjQjx/wZ32suKg tLkmuWzojwQfaJccE0cCPw6dvGqWI9IIj8nFxESti2usSEDaNPNnOxLCZG5ksZnA fknXSBSBTZZHti8d9zmL =IhHf -----END PGP SIGNATURE----- --=-=-=--