From owner-freebsd-current@FreeBSD.ORG Tue Nov 8 15:30:02 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B1361065674 for ; Tue, 8 Nov 2011 15:30:02 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id B8EED8FC19 for ; Tue, 8 Nov 2011 15:30:01 +0000 (UTC) Received: by wyg36 with SMTP id 36so833262wyg.13 for ; Tue, 08 Nov 2011 07:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=pLNZILDZfcMEZQJcv3GYaatKtRv1kw8PFWlQPveplAg=; b=i2CCzO7AYdPErOXDPp++Dx5U399nsZ4xzH3asvGtkoJ29mNta3hKFkphIIwaP23+1+ p2B9OxbgbEyuYZLn08wjztKDrXIiQts0HcLzI9UE9mp7+iG5H67DGzVkg5KTaaIJMBYu l5plXedxNpfisZ+yqSVbqih0P9PiGcynNhnjM= MIME-Version: 1.0 Received: by 10.180.95.134 with SMTP id dk6mr12545021wib.59.1320766200838; Tue, 08 Nov 2011 07:30:00 -0800 (PST) Received: by 10.180.8.34 with HTTP; Tue, 8 Nov 2011 07:30:00 -0800 (PST) In-Reply-To: References: Date: Tue, 8 Nov 2011 10:30:00 -0500 Message-ID: From: Ryan Stone To: Paul Ambrose Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current Subject: Re: [PATCH] Fix types of arguments to dtrace syscall return probes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2011 15:30:02 -0000 On Mon, Nov 7, 2011 at 9:16 AM, Paul Ambrose wrote: > diff --git a/sys/kern/kern_ctf.c b/sys/kern/kern_ctf.c > index bdff96e..2737860 100644 > --- a/sys/kern/kern_ctf.c > +++ b/sys/kern/kern_ctf.c > @@ -90,7 +90,7 @@ link_elf_ctf_get(linker_file_t lf, linker_ctf_t *lc) > =A0 =A0 =A0 =A0 * ctfcnt to -1. See below. > =A0 =A0 =A0 =A0 */ > =A0 =A0 =A0 =A0if (ef->ctfcnt < 0) > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return (0); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return (EFTYPE); > > =A0 =A0 =A0 =A0/* Now check if we've already loaded the CTF data.. */ > =A0 =A0 =A0 =A0if (ef->ctfcnt > 0) { > -------------------------------------------------------------------------= -------------- I have committed this as r227342. Thanks for the fix. > And I post another fix for the ${NORMAL_CTFCONVERT} issue, could you > check it for me? Yes, I can take a look. > =A0kern/160307, I check the /boot/kernel/kernel with ctfdump, and found > the kernel image has right ctf information, do you > have any idea? Offhand, no. I'll try to find some time to look at your PRs.