From owner-freebsd-net@FreeBSD.ORG Tue Feb 3 18:44:33 2015 Return-Path: <owner-freebsd-net@FreeBSD.ORG> Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AF300894 for <freebsd-net@freebsd.org>; Tue, 3 Feb 2015 18:44:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8CE37154 for <freebsd-net@freebsd.org>; Tue, 3 Feb 2015 18:44:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t13IiX5f019676 for <freebsd-net@freebsd.org>; Tue, 3 Feb 2015 18:44:33 GMT (envelope-from mat@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t13IiXQm019675; Tue, 3 Feb 2015 18:44:33 GMT (envelope-from mat) Date: Tue, 3 Feb 2015 18:44:33 +0000 To: freebsd-net@freebsd.org From: "adrian (Adrian Chadd)" <phabric-noreply@FreeBSD.org> Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <121233fc036c2c4edbbe9aad6c8738ea@localhost.localdomain> X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none X-Phabricator-To: <PHID-USER-mdwvnzzsrozqcmzhmbra> X-Phabricator-To: <PHID-USER-m5kr3wee75e5cxyh26hv> X-Phabricator-To: <PHID-USER-nb2boxugvmpo7syia5md> X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3> X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr> X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g> X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf> X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii> X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v> X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t> X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc> In-Reply-To: <differential-rev-PHID-DREV-wifan4aus5qtbwh2gnxc-req@FreeBSD.org> References: <differential-rev-PHID-DREV-wifan4aus5qtbwh2gnxc-req@FreeBSD.org> Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFTRFxE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: <differential-comment> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/> List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 03 Feb 2015 18:44:33 -0000 adrian added a comment. *laugh* I know you're not; I'm just worried that we'll have lots of subtle bugs here and there with the semantics of "sometimes the length is in ip_hdr; sometimes the length is in m_pkthdr; and there's no clear definition of when we should check both." If we had a clearer definition of that and we had accessor macros that abstracted that away, it'll make things clearer and it'll give us a place to put assertions about our assumptions. REVISION DETAIL https://reviews.freebsd.org/D1761 To: hselasky, rmacklem, rrs, glebius, gnn, emaste, imp, adrian, bz, rwatson Cc: freebsd-net