From owner-cvs-src@FreeBSD.ORG Thu May 29 15:00:12 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67B7237B407 for ; Thu, 29 May 2003 15:00:12 -0700 (PDT) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4976D43FA3 for ; Thu, 29 May 2003 15:00:10 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4347 invoked from network); 29 May 2003 22:00:07 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 29 May 2003 22:00:07 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h4TM03p0085672; Thu, 29 May 2003 18:00:04 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030529215252.GF21011@elvis.mu.org> Date: Thu, 29 May 2003 18:00:15 -0400 (EDT) From: John Baldwin To: Maxime Henrion cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/sys/kern kern_sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2003 22:00:12 -0000 On 29-May-2003 Maxime Henrion wrote: > Nate Lawson wrote: >> On Thu, 29 May 2003, Maxime Henrion wrote: >> > Modified files: >> > sys/kern kern_sysctl.c >> > Log: >> > When loading a module that contains a sysctl which is already compiled >> > in the kernel, the sysctl_register() call would fail, as expected. >> > However, when unloading this module again, the kernel would then panic >> > in sysctl_unregister(). Print a message error instead. >> > >> > + /* >> > + * This can happen when a module fails to register and is >> > + * being unloaded afterwards. It should not be a panic() >> > + * for normal use. >> > + */ >> > + if (error) >> > + printf("%s: failed to unregister sysctl\n", __func__); >> >> Thank you, this is helpful. However, we have quite a few error messages >> that appear when an attach fails. Is this one necessary in practice or >> should the eventual plan be to change the API to return an errno? (Note, >> not talking about 5.1 here). > > I agree with you that we should think about this issue a bit more once > 5.1 is out, as I'm not comfortable with this error message. However, if > I remember right, changing the API is not an option after 5.1 since we > promised to not break APIs and ABIs past this release. If the message > turns out to be annoying, it can be removed a bit later and we can have > sysctl_unregister() silently fail. Changing the API would probably be > better, but I bet we'll have to do this for 6.0. AFAIK, the API and ABI is not frozen until RELENG_5 is branched. That isn't happening at 5.1 release, so there is still some time to fix the API/ABI if need be. We really should start avoiding making API/ABI changes though after 5.1 is out. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/