From owner-cvs-src@FreeBSD.ORG Mon Nov 28 21:37:38 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD26616A41F; Mon, 28 Nov 2005 21:37:38 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6246243D6D; Mon, 28 Nov 2005 21:37:27 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 2756548 for multiple; Mon, 28 Nov 2005 16:37:19 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jASLaw2S063566; Mon, 28 Nov 2005 16:37:05 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Mon, 28 Nov 2005 16:37:09 -0500 User-Agent: KMail/1.8.2 References: <200511211839.jALIdIff064683@repoman.freebsd.org> <200511281527.41530.jhb@freebsd.org> <438B7144.2050709@samsco.org> In-Reply-To: <438B7144.2050709@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511281637.11153.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2005 21:37:39 -0000 On Monday 28 November 2005 04:06 pm, Scott Long wrote: > John Baldwin wrote: > > On Monday 21 November 2005 01:39 pm, John Baldwin wrote: > >>jhb 2005-11-21 18:39:17 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/amd64/amd64 machdep.c > >> Log: > >> Expand the hack to mask the atpics if 'device atpic' is not in the > >> kernel during boot up. Now we do a full reset of the 8259As and setup a > >> simple interrupt handler (we actually borrow the apic one that just does > >> an immediate iret) to handle any spurious interrupts triggered by either > >> chip. This should fix some folks that were getting a Trap 30 during > >> bootup of certain SMP AMD systems. This might get pushed into the 6.0 > >> branch as an errata. For now a suitable workaround is to add 'device > >> atpic' to your kernel config. > >> > >> Tested by: scottl > >> Helpful info from: dillon > >> MFC after: 1 week > > > > Hmm, we probably still need to reprogram the ATPIC on resume as well. > > I'm not sure it's actually worth not just compiling the atpic code in on > > amd64. > > Problems aside, what are the benefits to not having the atpic > unconditionally included on amd64? Purely space savings. It's whatever the size of atpic.o, elcr.o, and the bits of atpic_vector.S that make it into exception.o are. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org