Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 02 Feb 2015 18:43:39 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 197258] [maintainer update] audio/id3mtag: update to 0.79
Message-ID:  <bug-197258-13-CfLeGWMT2U@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-197258-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-197258-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197258

Dmitry Marakasov <amdmi3@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-ports-bugs@FreeBSD. |amdmi3@FreeBSD.org
                   |org                         |
         Resolution|---                         |FIXED
                 CC|                            |amdmi3@FreeBSD.org
             Status|New                         |Closed

--- Comment #2 from Dmitry Marakasov <amdmi3@FreeBSD.org> ---
Committed with minor change (added LICENSE_FILE).

Since you're the author, I suggest to fix the makefile to not override flags
set in environment. This will make building with pre-set environment and from
packaging systems easier. In particular, with FreeBSD ports it'll allow to drop
MAKE_ARGS.

---
-CC      = cc
-CXX     = c++
-CFLAGS  = $(WARNINGS:%=-W%) -pedantic -g -Os
-CXXFLAGS = $(CFLAGS) -fno-rtti
-LDFLAGS  =
+CC      ?= cc
+CXX     ?= c++
+CFLAGS  += $(WARNINGS:%=-W%) -pedantic -g -Os
+CXXFLAGS += $(WARNINGS:%=-W%) -pedantic -g -Os -fno-rtti
+LDFLAGS  +=
---

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197258-13-CfLeGWMT2U>