From owner-cvs-src@FreeBSD.ORG Tue Sep 19 20:06:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A435016A412; Tue, 19 Sep 2006 20:06:56 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id E34FE43D45; Tue, 19 Sep 2006 20:06:53 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id BADC45C65; Wed, 20 Sep 2006 00:06:51 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id 981605C57; Wed, 20 Sep 2006 00:06:51 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k8JK6q6A023630; Wed, 20 Sep 2006 00:06:52 +0400 (MSD) (envelope-from ru) Date: Wed, 20 Sep 2006 00:06:52 +0400 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20060919200652.GC23360@rambler-co.ru> References: <200609151328.k8FDSAGM094520@repoman.freebsd.org> <20060919194959.GA3692@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UPT3ojh+0CqEDtpF" Content-Disposition: inline In-Reply-To: <20060919194959.GA3692@dragon.NUXI.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/awk main.c.diff X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 20:06:56 -0000 --UPT3ojh+0CqEDtpF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 19, 2006 at 12:49:59PM -0700, David O'Brien wrote: > On Fri, Sep 15, 2006 at 01:28:10PM +0000, Ruslan Ermilov wrote: > > ru 2006-09-15 13:28:10 UTC > > FreeBSD src repository > > Modified files: > > usr.bin/awk main.c.diff=20 > > Log: > > Don't require a space between -[fv] and its argument. > > PR: bin/86514 >=20 > I really don't think changes like this should be committed unless they > also get upstream first. We have BWK awk and by changing it, things > "tested" on FreeBSD aren't portable other platforms using BWK awk. >=20 I'm pretty sure it will be accepted by Brian since another option already allowed its argument to be specified without a preceding space, and I don't share your argument of "this is BWK awk". I think it's more important to be POSIX-compliant than BWK-compliant, even if it means to change vendor code. Of a particular interest is item 2.c of POSIX's Utility Argument Syntax. : The awk utility shall conform to the Base Definitions volume of : IEEE Std 1003.1-2001, Section 12.2, Utility Syntax Guidelines. : Utility Syntax Guidelines : [...] : Guideline 6: : Each option and option-argument should be a separate argument, : except as noted in Utility Argument : Syntax , item (2). : Utility Argument Syntax : utility_name[-a][-b][-c option_argument] : [-d|-e][-foption_argument][operand...] :=20 : The notation used for the SYNOPSIS sections imposes requirements : on the implementors of the standard utilities and provides a : simple reference for the application developer or system user. :=20 : [...] :=20 : 2. Option-arguments are sometimes shown separated from their : options by s, sometimes directly : adjacent. This reflects the situation that in some cases an : option-argument is included within the same argument string : as the option; in most cases it is the next argument. The : Utility Syntax Guidelines in Utility Syntax Guidelines require : that the option be a separate argument from its option-argument, : but there are some exceptions in IEEE Std 1003.1-2001 to : ensure continued operation of historical applications: :=20 : a. If the SYNOPSIS of a standard utility shows a : between an option and option-argument (as : with [ -c option_argument] in the example), a conforming : application shall use separate arguments for that option : and its option-argument. :=20 : b. If a is not shown (as with [ -f option_argument] : in the example), a conforming : application shall place an option and its option-argument : directly adjacent in the same argument string, without : intervening s. :=20 : c. Notwithstanding the preceding requirements on conforming : applications, a conforming : implementation shall permit an application to specify : options and option-arguments as a single argument or : as separate arguments whether or not a is shown : on the synopsis line, ^[XSI] [Option Start] except in : those cases (marked with the XSI portability warning) : where an option-argument is optional and no separation : can be used. [Option End] : = =20 : d. A standard utility may also be implemented to operate : correctly when the required separation into multiple : arguments is violated by a non-conforming application. =20 > > MFC after: 3 days >=20 > Please don't. > =20 Too late. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --UPT3ojh+0CqEDtpF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFEE3cqRfpzJluFF4RAtCwAJ4ksnhPbNVQX0q9VK5cu4uVBrMGAgCglg07 MGYIpRe9B88l7xO28Am1kKU= =tl51 -----END PGP SIGNATURE----- --UPT3ojh+0CqEDtpF--