From owner-svn-src-head@freebsd.org Mon Mar 6 01:43:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5EA2CF7A59; Mon, 6 Mar 2017 01:43:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3CDF1867; Mon, 6 Mar 2017 01:43:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id j5so15886771pfb.3; Sun, 05 Mar 2017 17:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xeI+91DTWsER4immuEpm9zeUVml/VSixmQ4Yp0KzlkY=; b=rjsz8UWK0fVidxlOSDhNuYB4udogn4UWFO+aEYQOOJXeoCsXF3E/dRH8/Tnjm6rVdV 60m9fM3EkcFVoMpzoouuA1doR4YzNBN/oiVM2MoAw60d/niML4E/HUE1uhIOFXyVy+j5 yflQLBZutgAU7hlNW9sDxQHE3fDwXY38CesVjYov4AHPo2ssAjmBC5bqX5JgjMZYAftn +LJn24ji38hjq0eQCU6CQdkhElxadGq9IIq/rS8ElWdcZfluLKijnBMd+2x+eXn/MLjs mPdPKLg0JrdgAnCGSnsIr7fu/vL0NdGgt4CG7tO8nuvHOwP1cr5cLBqlOYL6VKrJePgm Uz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xeI+91DTWsER4immuEpm9zeUVml/VSixmQ4Yp0KzlkY=; b=Si5ZgayI4unatjy+VekLOSLn0R3UIAqXSgqW9SWV7gRsPQQ0soNlAeTS/fw04IPvKR Zw3yOnWvuMGvnqv3Rr8QsHbu58W5p0J8+Jkc8rjSvkncmvhmCDSiZhm6PjRjgStbx1qx WuPzo3HXmBHyBaIGla48PaynDXCu0ZTXdNdc2HmQaHdo3Y+NDYa2CzfwcNn3hOLUofXU hL/JGcnHQD3KSivvztXSN5b0OdbarjbKKSAmbM/KY8OVGh2ioe/MHqGozJAmOPiQe1Is bfmnUhItc1KVTGe5ph8czoacemF5sDpqyVs+6vasAcZulEQMxFTTU0+nOYwitt1u4bQy JmDg== X-Gm-Message-State: AMke39ny1fQ56vB7XISQ9DuZcpwMgilynqlJKM9LtkhT96kx7iSdSZl4W4jrrqNHF2iBBA== X-Received: by 10.99.238.5 with SMTP id e5mr17183958pgi.49.1488764609813; Sun, 05 Mar 2017 17:43:29 -0800 (PST) Received: from ?IPv6:2607:fb90:2786:84e5:b134:3c24:b080:8a96? ([2607:fb90:2786:84e5:b134:3c24:b080:8a96]) by smtp.gmail.com with ESMTPSA id e2sm35754261pga.61.2017.03.05.17.43.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Mar 2017 17:43:28 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r314654 - in head/cddl: lib/drti lib/libavl lib/libctf lib/libdtrace lib/libnvpair lib/libumem lib/libuutil lib/libzfs lib/libzfs_core lib/libzpool sbin/zfs sbin/zpool usr.bin/ctfconver... From: Ngie Cooper X-Mailer: iPhone Mail (14D27) In-Reply-To: <7B9F63AD-4EC4-4D5E-884B-3D0A22AB3952@rpi.edu> Date: Sun, 5 Mar 2017 17:43:27 -0800 Cc: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: <9494378A-5164-4C0A-B99A-6B9E91A281ED@gmail.com> References: <201703042039.v24KdcDE078734@pdx.rh.CN85.dnsmgr.net> <03156186-221F-4EEB-A86E-077E46E28296@gmail.com> <7B9F63AD-4EC4-4D5E-884B-3D0A22AB3952@rpi.edu> To: Garance A Drosehn X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 01:43:31 -0000 > On Mar 5, 2017, at 17:05, Garance A Drosehn wrote: >=20 > On 4 Mar 2017, at 15:42, Ngie Cooper (yaneurabeya) wrote: >=20 >>> On Mar 4, 2017, at 12:39, Rodney W. Grimes wrote: >>>=20 >>>> On 4 Mar 2017, at 15:13, Bryan Drewery wrote: >>>>=20 >>>> Where is this discussion? The only one I can find is >>>> https://reviews.freebsd.org/D9207 which seems to have >>>> a consensus of moving to SRCTOP and :H vs '../..'. >>>=20 >>> There was a short discussion here on the commiters list >>> with some others expressing the preferred the relative >>> status of things even though it clutters logs. >>>=20 >>> D9207 touches 15 files.. I would not consider that an >>> adequate review that is actually going to change nearly >>> every Makefile in the tree, and change what people have >>> been looking and at working with for 30 years. >>>=20 >>> I don't think any differntial that only had 3 or 4 people >>> involved that is going to effect all developers is >>> adequate either. Tree wide sweeping changes should be >>> discussed far more widely. >>>=20 >>> Idk, maybe I am to personally attached to the relative >>> paths.. cause I had a major part in helping them all to >>> work, or perhaps its my been burned by absolute paths >>> that had to be reworked too many times in my past. But >>> my gut is telling me this change is Bad(tm). >>=20 >> I care about this for the reasons brewery posted, but I >> also care because it slows down my terminal output and >> it bloats my disk with typescript logs that contain >> unnecessary information. >=20 > FWIW, here was my method to fix the "slows down output" issue. > I wrote a wrapper around 'make' which I called "wcmake", and > it runs the output from a 'make' command through a script > which does a variety of analysis on that output. >=20 > Among other things, it truncates the lines of make-output to > screen width, but it saves the full output to a temp file, and > then compresses that temp file. It also parses and condenses > the output so what the user sees at the console looks like: >=20 > cc -c /usr/src/usr.bin/make/arch.c -O2 -pipe -I/usr/src/usr.bin/make -DMAK= E_V|+ > cc -c /usr/src/usr.bin/make/buf.c -O2 -pipe -I/usr/src/usr.bin/make -DMAKE= _VE|+ > cc -c /usr/src/usr.bin/make/cond.c -O2 -pipe -I/usr/src/usr.bin/make -DMAK= E_V|+ >=20 > instead of: >=20 > cc -O2 -pipe -I/usr/src/usr.bin/make -DMAKE_VERSION=3D\"9201210220\" -DDEFS= HELLNAME=3D\"sh\" -std=3Dgnu99 -fstack-protector -Wsystem-headers -Wall -Wn= o-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototyp= es -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshad= ow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-exter= ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/us= r.bin/make/arch.c -o arch.o >=20 > cc -O2 -pipe -I/usr/src/usr.bin/make -DMAKE_VERSION=3D\"9201210220\" -DDEFS= HELLNAME=3D\"sh\" -std=3Dgnu99 -fstack-protector -Wsystem-headers -Wall -Wn= o-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototyp= es -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshad= ow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-exter= ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/us= r.bin/make/buf.c -o buf.o >=20 > cc -O2 -pipe -I/usr/src/usr.bin/make -DMAKE_VERSION=3D\"9201210220\" -DDEFS= HELLNAME=3D\"sh\" -std=3Dgnu99 -fstack-protector -Wsystem-headers -Wall -Wn= o-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototyp= es -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshad= ow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-exter= ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/us= r.bin/make/cond.c -o cond.o >=20 > # [I added blank-lines between the lines of make-output, so > # it doesn't look so much like a solid wall of characters] >=20 > (ie, it moves the '-c filename' to the start of the line, strips > the setting of any environment variables at the start, and tacks > on the '|+' at the end if it has truncated the line). It also > parses the output looking for warning messages, and writes a > summary of messages-seen after the 'make' has finished. >=20 > One of the goals was to speed up buildworld's when I was doing > them via a serial console-session or over a slow ssh-connection. > But this way if something really bad or odd *did* come up, I > could look at the original full make-output which was saved on > disk. Adding a wrapper-script obviously adds more CPU work to > the build, but my builds definitely finished faster as-far-as > wall-clock time because I was writing so much less output to > the console. >=20 > I have two versions of this script, and I don't remember why > there are two versions. The first one was written in perl, and > later I wrote a second one in ruby. Both are under ~gad/scripts > on the machines at freebsd.org. I'm sure the code in the > scripts is probably lousy and somewhat embarrassing (to me), > but you could at least check them out and see where I was > going with it. >=20 > disclaimer: I haven't taken a serious look at these scripts a > few years. I'm sure they need to be updated due to new commands > and new warning messages which have appeared since then. Hi! Have you considered using make -s instead? It definitely abbreviates the= output quite a bit... I probably could do similar for my local builds. Our Jenkins runs don't d= o that, but maybe they should though.. Thanks, -Ngie=