From owner-freebsd-threads@FreeBSD.ORG  Sun Mar 21 01:45:56 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7EE0E16A4CE
	for <threads@freebsd.org>; Sun, 21 Mar 2004 01:45:56 -0800 (PST)
Received: from smtp.mho.com (smtp.mho.net [64.58.4.5])
	by mx1.FreeBSD.org (Postfix) with SMTP id 4F50943D41
	for <threads@freebsd.org>; Sun, 21 Mar 2004 01:45:56 -0800 (PST)
	(envelope-from scottl@freebsd.org)
Received: (qmail 31469 invoked by uid 1002); 21 Mar 2004 09:45:55 -0000
Received: from unknown (HELO freebsd.org) (64.58.1.252)
  by smtp.mho.net with SMTP; 21 Mar 2004 09:45:55 -0000
Message-ID: <405D637A.2060307@freebsd.org>
Date: Sun, 21 Mar 2004 02:42:18 -0700
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Julian Elischer <julian@elischer.org>
References: <Pine.BSF.4.21.0403210125430.17893-100000@InterJet.elischer.org>
In-Reply-To: <Pine.BSF.4.21.0403210125430.17893-100000@InterJet.elischer.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: threads@freebsd.org
Subject: Re: Who can commit this.. kse vs ULE
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Mar 2004 09:45:56 -0000

Thanks.  What is the problem that is referred to in the email?  This
patch looks to be a hack.

Scott

Julian Elischer wrote:
> Scott here's the patch I mentioned...
> ---------- Forwarded message ----------
> Date: Wed, 17 Mar 2004 18:30:45 -0800
> From: David O'Brien <obrien@freebsd.org>
> To: Taku YAMAMOTO <taku@cent.saitama-u.ac.jp>
> Cc: freebsd-current@freebsd.org
> Subject: Re: [PATCH] for SCHED_ULE & libpthread issue (was Re: I like
> 
> 	SCHED_4BSD)
> 
> On Fri, Mar 12, 2004 at 09:23:47AM +0900, Taku YAMAMOTO wrote:
> 
>>Until the problem is fully addressed, I will propose following patch
>>to be applied. (the least intrusive one attached in the former message)
> 
>  
> Do people think we should commit this?
> 
> --- sched_ule.c.orig	Fri Feb 13 05:24:48 2004
> +++ sched_ule.c	Fri Feb 13 05:37:53 2004
> @@ -186,7 +186,7 @@
> #define	SCHED_INTERACTIVE(kg)						\
>      (sched_interact_score(kg) < SCHED_INTERACT_THRESH)
> #define	SCHED_CURR(kg, ke)						\
> -    (ke->ke_thread->td_priority != kg->kg_user_pri ||			\
> +    (ke->ke_thread->td_priority < kg->kg_user_pri ||			\
>      SCHED_INTERACTIVE(kg))
>  
>  /*
> @@ -1166,11 +1166,8 @@
>  	 */
>  	if ((ke->ke_flags & KEF_ASSIGNED) == 0) {
>  		if (TD_IS_RUNNING(td)) {
> -			if (td->td_proc->p_flag & P_SA) {
> -				kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke);
> -				setrunqueue(td);
> -			} else 
> -				kseq_runq_add(KSEQ_SELF(), ke);
> +			kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke);
> +			setrunqueue(td);
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
> 
>