From owner-svn-src-all@FreeBSD.ORG Mon Jul 1 17:06:12 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BC4005DC; Mon, 1 Jul 2013 17:06:12 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) by mx1.freebsd.org (Postfix) with ESMTP id 98078168D; Mon, 1 Jul 2013 17:06:12 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r61H65Yc041597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Jul 2013 10:06:06 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r61H65wI041596; Mon, 1 Jul 2013 10:06:05 -0700 (PDT) (envelope-from jmg) Date: Mon, 1 Jul 2013 10:06:05 -0700 From: John-Mark Gurney To: Peter Wemm Subject: Re: svn commit: r252458 - head/lib/libc/iconv Message-ID: <20130701170605.GM26412@funkthat.com> References: <201307010806.r6186QmN027318@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201307010806.r6186QmN027318@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Mon, 01 Jul 2013 10:06:06 -0700 (PDT) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jul 2013 17:06:12 -0000 Peter Wemm wrote this message on Mon, Jul 01, 2013 at 08:06 +0000: > Initialize the pthread rwlock. Note that upstream has three > separate locks. The file-local static lock appears intentional. I believe that when I was tracing the lock issues, that there were some deadlocks that can occur even w/ separate locks. I did post a patch that made the lock a single lock and avoided the issues w/ the lock, but as I didn't have time to test it, never committed it. This definitely needs some real software engineering applied to it, either put this declaration in the respective files (so that if someone uses this is a new file, they won't get burned) and comments around the macros that it isn't a global lock. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."