From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 14 07:14:38 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2067F49 for ; Wed, 14 May 2014 07:14:38 +0000 (UTC) Received: from mail.musha.org (v055125.ppp.asahi-net.or.jp [124.155.55.125]) by mx1.freebsd.org (Postfix) with ESMTP id 9FB0921D0 for ; Wed, 14 May 2014 07:14:37 +0000 (UTC) Received: by mail.musha.org (Postfix, from userid 58) id 3gT6Zj2BHQzZ07R; Wed, 14 May 2014 16:14:37 +0900 (JST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on daemon.musha.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=13.0 tests=BAYES_00, CONTENT_TYPE_PRESENT,FAKEDWORD_ONE,FAKEDWORD_VERTICALLINE,ONLY1HOPDIRECT, RP_MATCHES_RCVD,SPF_HELO_FAIL,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.0 Received: from daemon.musha.org (daemon.local.idaemons.org [192.168.11.11]) by mail.musha.org (Postfix) with ESMTP id 3gT6Zh5lXDzZ07M for ; Wed, 14 May 2014 16:14:36 +0900 (JST) Date: Wed, 14 May 2014 16:14:36 +0900 Message-ID: <86d2fghlwj.knu@iDaemons.org> From: "Akinori MUSHA" To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/189158: update for ports/sysutils/zfs-snapshot-clean In-Reply-To: <201405010420.s414K3h5024688@freefall.freebsd.org> References: <201405010420.s414K3h5024688@freefall.freebsd.org> Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 07:14:38 -0000 Hi, Thanks for the work! The patch looks good, but I have a couple of questions. > 1. There is no PATH setting. Why would you need PATH to be set in this command? I mean, which exactly commands are not in the default paths? I would rather append or prepend neccessary directories to PATH than to completely override it. > 3. On Solaris, This script does not work. Because /bin/sh on Solaris > does not support "$(command)" syntax. I think this command tries to invoke itself with /usr/xpg4/bin/sh if `local` is missing. Which in the following is the case? a. /bin/sh does support `local` but does not support $(). b. /bin/sh does not support `local` and /usr/xpg4/bin/sh does not support $(). I'm asking this because the $(...) construct has been specified in POSIX/SUS for a very long time, and I expect /usr/xpg4/bin/sh to support it. Best Regards, -- Akinori MUSHA / https://akinori.org/