From owner-freebsd-cvsweb@FreeBSD.ORG Tue Aug 12 10:34:47 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 25C7337B401 for ; Tue, 12 Aug 2003 10:34:47 -0700 (PDT) Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CB4A43F3F for ; Tue, 12 Aug 2003 10:34:46 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp3.pp.htv.fi (Postfix) with ESMTP id 2B2AB27B18C; Tue, 12 Aug 2003 20:34:45 +0300 (EEST) Received: from cs78130147.pp.htv.fi (cs78130147.pp.htv.fi [62.78.130.147]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id h7CHYi519841; Tue, 12 Aug 2003 20:34:44 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: PC32 XHChen In-Reply-To: References: Content-Type: text/plain Organization: FreeBSD Message-Id: <1060709683.15140.87.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.3 (1.4.3-0.vs.1) Date: 12 Aug 2003 20:34:43 +0300 Content-Transfer-Encoding: 7bit cc: freebsd-cvsweb@FreeBSD.org Subject: Re: FW: Graph of revisions for cvsweb.cgi X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2003 17:34:47 -0000 On Tue, 2003-08-12 at 13:13, PC32 XHChen wrote: > Dear all: > I modified cvsweb.cgi for supporting "graph selection" as what's in wincvs. > Thanks for trying it ! Whoo, that's pretty impressive stuff! However, a couple of points: Your modified version is done against FreeBSD-CVSweb 2.0.6; the rel-2_0-branch has been feature frozen. CVS HEAD contains the development version, all new features should be done there. See http://www.freebsd.org/cgi/cvsweb.cgi/projects/cvsweb/ The development version already uses cvsgraph from http://www.akhphd.au.dk/~bertho/cvsgraph/ to provide similar functionality. There are some naming conflicts that need to be sorted out before your version could be applied. Submissions are better sent as unified diffs (diff -u) instead of whole modified files. And I'd rather see the JavaScript code in a separate static .js file(s) instead of embedded in the cvsweb.cgi script, as much as possible. Or ported to Perl :) Could you port your change so that it applies against HEAD of cvsweb.cgi and possibly address the other issues above and send the results as a unified diff? What level of JavaScript support does the code require? It seems to work in my Mozilla Firebird 0.6.1. -- \/