From owner-svn-src-head@FreeBSD.ORG Mon Mar 1 22:44:52 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D89851065673; Mon, 1 Mar 2010 22:44:52 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id A83E98FC19; Mon, 1 Mar 2010 22:44:52 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 4701446B45; Mon, 1 Mar 2010 17:44:52 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id AE50E8A01F; Mon, 1 Mar 2010 17:44:51 -0500 (EST) From: John Baldwin To: Kostik Belousov Date: Mon, 1 Mar 2010 17:22:27 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201002281719.o1SHJM6u042302@svn.freebsd.org> <201003011030.51154.jhb@freebsd.org> <20100301221213.GY2489@deviant.kiev.zoral.com.ua> In-Reply-To: <20100301221213.GY2489@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201003011722.27155.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 01 Mar 2010 17:44:51 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.5 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204475 - head/sys/fs/msdosfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2010 22:44:52 -0000 On Monday 01 March 2010 5:12:13 pm Kostik Belousov wrote: > On Mon, Mar 01, 2010 at 10:30:51AM -0500, John Baldwin wrote: > > On Sunday 28 February 2010 12:19:22 pm Konstantin Belousov wrote: > > > Author: kib > > > Date: Sun Feb 28 17:19:22 2010 > > > New Revision: 204475 > > > URL: http://svn.freebsd.org/changeset/base/204475 > > > > > > Log: > > > Mark msdosfs as mpsafe. > > > > Are you planning on implementing support for LOOKUP_SHARED and > > EXTENDED_SHARED as well? > > Do you think it makes sense to do this for msdosfs ? > Please note that current msdosfs code exclusively uses exclusive locks > on the vnodes. > > One obvious issue with *_SHARED is the fat cache in the denode. Oh, hmm. I guess we would need to first allow it to use shared locks generically (VN_LOCK_ASHARE() for VOP_READ() and the like). I do think we should try to make our filesystems concurrent when it is not too terribly difficult. -- John Baldwin