From owner-svn-src-all@freebsd.org Sat Dec 31 00:39:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA664C96563; Sat, 31 Dec 2016 00:39:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A81A01E00; Sat, 31 Dec 2016 00:39:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x243.google.com with SMTP id n5so23496694pgh.3; Fri, 30 Dec 2016 16:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=o4T6MGMla19560tAROQ8tHybV5f3HeNw2DRSklpdTIc=; b=aUG0cacRQ3JH9qolnCKqX6PQnxD77ISdSArkdzQrPbUG8V2BRwsQEvzYPw2f3xlgID vlYVmdi73TTvrOCb4Q+/GO+3mB2sAFnIH6JOSoXpJLtXDct6qhjuTrcL0OKL8Jh5HRIG UMFx8BX0J4TzEQEQtftzyfRVmMW6KzLZ369w7flYL9l2nYe2yGhNKhDbF0nOz+KKO6Zy +RNyEMYezwp3GohvqFAQ7C3mYcLGiTaWHA1SGP70W6S+Tz+klSn95QuUd78lzPHxcfhB M65Cc+d6bNNV5vCsE1zlcV0QSFjEQhYycsxxnHh0BVrQhxS+HsjKnA6hfnxf2xnwQ+i1 AuBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=o4T6MGMla19560tAROQ8tHybV5f3HeNw2DRSklpdTIc=; b=trfsJYi/LohVObONARgd5yEYEdHL08gAc03V4TbQkzRhiaiAjyQP9Q32+EuByNJwU2 4KC86O/DuDR2vfHXhPmHC1tG9g0xUDuChqM59FIKlN6yuyvyUobPFr07JdwgJRK5UEV7 DLtRRtBNoLmKajSJT694m1ptjpb6Dx2kAuehhe5T6zs5vJT+VcbDAFfCeCaQzso0KdjV ML0BmXIeI1BJZt8TvoKAskWsJ+sfx27ipVzYOYPGDlPZXNzIEa7UWY6Jf9SULJztywUX sbki+AGdCYGcN9bGLIrz1lVpMrBy9ZGevB5bTUgcmRV1azvE/Xji7+3pu4xNmTnvtCUg J9mA== X-Gm-Message-State: AIkVDXJY1AS/N44R/ZESxZ5ZsWVX2dXIonMzfJAb0fZuFNmoOAzxbqN9uGrD6k/1HTN6UA== X-Received: by 10.99.22.65 with SMTP id 1mr89247148pgw.70.1483144798029; Fri, 30 Dec 2016 16:39:58 -0800 (PST) Received: from [192.168.20.12] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id p64sm115117955pfi.88.2016.12.30.16.39.57 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Dec 2016 16:39:57 -0800 (PST) Subject: Re: svn commit: r310729 - head/contrib/bsnmp/lib Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5578E5E5-03ED-4982-ACDA-6D15CBB48014"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201612290020.uBT0K31s082221@repo.freebsd.org> Date: Fri, 30 Dec 2016 16:39:56 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <711B3082-13F3-4893-917A-F158986F9863@gmail.com> References: <201612290020.uBT0K31s082221@repo.freebsd.org> To: Ngie Cooper X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2016 00:39:59 -0000 --Apple-Mail=_5578E5E5-03ED-4982-ACDA-6D15CBB48014 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Dec 28, 2016, at 16:20, Ngie Cooper wrote: >=20 > Author: ngie > Date: Thu Dec 29 00:20:03 2016 > New Revision: 310729 > URL: https://svnweb.freebsd.org/changeset/base/310729 >=20 > Log: > Prevent improper memory accesses after calling snmp_pdu_free and = snmp_value_free >=20 > snmp_pdu_free: set pdu->nbindings to 0 to limit the damage that > could happen if a pdu was reused after calling the function, and > as both stack and heap allocation types are used in contrib/bsnmp > and usr.sbin/bsnmpd. >=20 > snmp_value_free: NULL out value->v.octetstring.octets after calling > free on it to prevent a double-free from occurring. This commit identified a bug in the bsnmptools implementation: % bsnmpwalk -s 172.16.45.130:161 sysDescr.0 =3D fbsd12 3045910434 FreeBSD 12.0-CURRENT Bus error (core dumped) --Apple-Mail=_5578E5E5-03ED-4982-ACDA-6D15CBB48014 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYZv5cAAoJEPWDqSZpMIYVDnYQALjA5RX/zVZBGzglX7ZhUyVG PwmpkxqZbhz+FruFScUSUGz8RAqgtIICrB8DNg/1uhMCdx3NGia0pddHU4HpbI5T kiMpiT76QC65jxImMas1LpgGrWUGCOTZACH7f2EKarT71niah6bm4yHo+QP2hDv+ HkpoYcHA9U+3Lfulf8lZ94rBdy6sGEZi16BmI473U3S93/OKDGkScF+2T5oy7143 RL47XC3L/jgrcPl66IwnU4fWp7H+xkCY26LsLaifVnPT7SWiEgy9fkmJNRHQvRow GCfB5AJwxs8mfQeY7+NPzFob8YpG5GO2POlPxNeYciDsRvCpBSolf4No7bQyTW4l mia71KQHw/NEKyfMf/b6twW/grXm10IpkG2F/BUplyQiegaiFQukHJIdf+KAITQH qbrikPQQNB3BUAnPMWqjuUXl5hxnd53qv1hmF8UpzMb4Rzpu7YaGlMhX0xHH5RWC r9X8Jsoxqz2RDZEv+py2J7OdrO4L5zu+3Tq094b3hcxn3+PdX6Md6gzRc3s4Y8fX umE3meO5q+lYBB/qZerS6P5JdyaPARTCBSU5dDsdJAmG1gDgT1SCdCU9dqIFL9Dz kYGMDB0adB3hogbrnYljfJHZnslX9sKJzXg11TzUh1zYiIH7z+ehGd/yG1HSzx4M UAl4Y/aHGu00k61Kl4mF =/sft -----END PGP SIGNATURE----- --Apple-Mail=_5578E5E5-03ED-4982-ACDA-6D15CBB48014--