From owner-svn-src-all@FreeBSD.ORG Mon Jan 10 22:22:53 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEEF6106566B; Mon, 10 Jan 2011 22:22:53 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 751468FC18; Mon, 10 Jan 2011 22:22:53 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq8FABMOK02DaFvO/2dsb2JhbACECJIzjwOtTY4GgSGDN3QEhGeGIw X-IronPort-AV: E=Sophos;i="4.60,303,1291611600"; d="scan'208";a="104876587" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 10 Jan 2011 16:53:26 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 62E7BB3FBA; Mon, 10 Jan 2011 16:53:26 -0500 (EST) Date: Mon, 10 Jan 2011 16:53:26 -0500 (EST) From: Rick Macklem To: john.gemignani@isilon.com Message-ID: <569448948.110324.1294696406344.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <201101102135.p0ALZAhV095080@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.202] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE8 (Win)/6.0.10_GA_2692) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217242 - head/sys/rpc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2011 22:22:54 -0000 ----- Original Message ----- > Author: rmacklem > Date: Mon Jan 10 21:35:10 2011 > New Revision: 217242 > URL: http://svn.freebsd.org/changeset/base/217242 > > Log: > Fix a bug in the client side krpc where it was, sometimes > erroneously, assumed that 4 bytes of data were in the first > mbuf of a list by replacing the bcopy() with m_copydata(). > Also, replace the uses of m_pullup(), which can fail for > reasons other than not enough data, with m_copydata(). > For the cases where it isn't known that there is enough > data in the mbuf list, check first via m_len and m_length(). > This is believed to fix a problem reported by dpd at dpdtech.com > and george+freebsd at m5p.com. > > Reviewed by: jhb > MFC after: 8 days > Oops, I forgot to mention that john.gemignani at isilon.com spotted and reported this bug via email. Thanks go to him for that. rick