From owner-freebsd-current Sun Dec 29 21:38: 8 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95FE037B401; Sun, 29 Dec 2002 21:38:06 -0800 (PST) Received: from h00609772adf0.ne.client2.attbi.com (h00609772adf0.ne.client2.attbi.com [24.61.43.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFA6743EC5; Sun, 29 Dec 2002 21:38:05 -0800 (PST) (envelope-from rodrigc@attbi.com) Received: from h00609772adf0.ne.client2.attbi.com (localhost [127.0.0.1]) by h00609772adf0.ne.client2.attbi.com (8.12.6/8.12.6) with ESMTP id gBU5cBVK079341; Mon, 30 Dec 2002 00:38:11 -0500 (EST) (envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com) Received: (from rodrigc@localhost) by h00609772adf0.ne.client2.attbi.com (8.12.6/8.12.6/Submit) id gBU5cAi2079340; Mon, 30 Dec 2002 00:38:10 -0500 (EST) Date: Mon, 30 Dec 2002 00:38:10 -0500 From: Craig Rodrigues To: David Schultz Cc: current@FreeBSD.ORG, sparc64@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <20021230053810.GA79308@attbi.com> References: <200212300321.gBU3LMWB011861@bowie.private> <20021229202731.B22633@citusc.usc.edu> <20021230051705.GA5307@HAL9000.homeunix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021230051705.GA5307@HAL9000.homeunix.com> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Dec 29, 2002 at 09:17:05PM -0800, David Schultz wrote: > Thus spake Kris Kennaway : > > On Mon, Dec 30, 2002 at 03:21:22AM +0000, Mike Barcroft wrote: > > > > > ===> sbin/swapon > > > cc1: warnings being treated as errors > > > /tinderbox/sparc64/src/sbin/swapon/swapon.c: In function `swaplist': > > > /tinderbox/sparc64/src/sbin/swapon/swapon.c:246: warning: field width is not type int (arg 3) > > > > Can someone please just fix this (by backing out the offending commit, > > if necessary)? > > Eek, given a 64-bit size_t, the present code leaves 32 bits of it > uninitialized in the usual case. The following patch ought to fix > the problem; I can't make sure right now because I'm out of town. I'm not sure if your patch will solve the problem. The offending code is here: 240 if (lflag) { 241 char buf[32]; 242 snprintf(buf, sizeof(buf), "%ld-blocks", blocksize); 243 printf("%-13s %*s %*s\n", 244 "Device:", 245 hlen, buf, 246 hlen, "Used:"); 247 } Doesn't the printf() statement in question have the wrong number of arguments? -- Craig Rodrigues http://www.gis.net/~craigr rodrigc@attbi.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message