From nobody Mon Jan 15 17:02:17 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TDJNV0PSTz57696 for ; Mon, 15 Jan 2024 17:02:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TDJNT1Frzz45MC for ; Mon, 15 Jan 2024 17:02:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=dXryWgsd; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::629) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a2821884a09so755806366b.2 for ; Mon, 15 Jan 2024 09:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1705338148; x=1705942948; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t2STmHmCmF5T4bBZstb6x5G6Bw/zRP8k8tpRxYOVTA0=; b=dXryWgsdeIA5WT/SLdpaVfoxFvRxeY3tB/okwZpuMVX0OcDY/ASJzUAlo/ivWsGXD8 GcsMjjb/b+zBoPRcW5I2bBdT3l9mkZ0N91uzrjDq7iRMhNJ3nK+DUjRpPk0VUpdrGc8R f7IerPE+pFm7LT1Yj3iRoZbx3zOCNWHrJZLyd1SiAWf1JE9sTs45DlOo58nefnLIIjYY CaKLav6PcVF7aZlS0dQZWhQnEfeQ/mgs03ssDSAKaUBnGgfYuyxhfWs3nNAmbQo2Mnd7 18tBM0AmhnJaQd9Pr6/ybtwX+mnQ0DkoUg6PjcuvhKUIuS9hp52sQ/lyYY+rVb4trNKH vXxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705338148; x=1705942948; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t2STmHmCmF5T4bBZstb6x5G6Bw/zRP8k8tpRxYOVTA0=; b=UprWOSh3Ag3I9gA7xHCqBwXlSAVDGOqGs2ha5dGLe66EPFjmazAMTAgdxp8Xq2ztAN o09QoiaSWIb0UM+pAdg0ymR1CdRLpscWUMbgKS0vHpqCPE1vpzxv9nXfp+ht3Pm8zZ+U 3WUHbEopFZjF2LWbM41qPojxHwah0VCskANe5X6RFSFp0Q+PVRNfF9s3HDLlWQ0CZxue zQairVie2HY/O8ttPQL+zUV5ZLHTccCdSfLWVqHV9S4he9BidcNHEiQFZo/rbSF/rBZS Zr7tAp/9bCfRBZI8oT/7hCO9ZVRlDHjBqtVXsnY6TjO4qkwAUIoXvVzAb+ax+HBPECOy rCdA== X-Gm-Message-State: AOJu0YwNm2a9/t+VIIS4XcNfX2nhwdtWv4ox1FRQLOAQMEbuqio5PW4y KpIS7pRoxDOwGpslrmCs6pqUrEPpNKSa4aO/zpUypgJMmy2tf82uuHzBH6gBGAY= X-Google-Smtp-Source: AGHT+IFx/Sf+hg00qOiBrQQCjPEqF59zDsRI2R2FvRvjzOY9q5lH9q8F+I+bRklnTF+jWfljxJ1OLoVPLba8xd5g0wE= X-Received: by 2002:a17:907:2da1:b0:a28:5901:70dd with SMTP id gt33-20020a1709072da100b00a28590170ddmr4037591ejc.17.1705338148601; Mon, 15 Jan 2024 09:02:28 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 15 Jan 2024 10:02:17 -0700 Message-ID: Subject: Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log To: John Baldwin Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000091d0f6060efefa28" X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::629:from]; DMARC_NA(0.00)[bsdimp.com]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; R_SPF_NA(0.00)[no SPF record]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4TDJNT1Frzz45MC --00000000000091d0f6060efefa28 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey John, On Mon, Jan 15, 2024 at 9:37=E2=80=AFAM Warner Losh wrote: > > > On Mon, Jan 15, 2024 at 9:30=E2=80=AFAM John Baldwin wr= ote: > >> On 1/14/24 6:24 PM, Warner Losh wrote: >> > The branch main has been updated by imp: >> > >> > URL: >> https://cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc78c03cb6b35f074ae43= 673c9ce463 >> > >> > commit df834e06bbc78c03cb6b35f074ae43673c9ce463 >> > Author: Warner Losh >> > AuthorDate: 2024-01-15 02:22:04 +0000 >> > Commit: Warner Losh >> > CommitDate: 2024-01-15 02:23:45 +0000 >> > >> > git-arc: Just strip escape sequences form arc log >> > >> > Just strip escape sequences and Warning: lines from 'arc list' >> output. I >> > upgraded and they changed and git arc list broke. This restores i= ts >> > functionality. >> > >> > Note: jhb didn't like this, so if others object, I'll fix... >> > >> > Sponsored by: Netflix >> > Reviewed by: markj >> > Differential Revision: https://reviews.freebsd.org/D36553 >> >> Namely, it breaks the color output for reviews in different states, so >> Needs Review >> shows up as purple, Approved as green, etc. If you find the color outpu= t >> useful >> you'll have to revert this locally. >> >> Also, your last update in the review said that git arc was no longer >> broken for you >> back in May implying this commit wasn't needed for git arc to work for >> you? >> > > Yes and no. I was mistaken. This change is still needed, but its scope ca= n > be reduced. > The trouble is that it's at the first for the other things I committed an= d > getting it out of the > way was a pain (I tried). Since I didn't want to delay things any further= , > I went ahead and > committed and thought I'd fix stuff if there were objections.I'll do that > now. > So even w/o my change, I don't see the color output for the review states (so I can remove the general filter I added for color). That's easy enough. but what are you doing to get color in the current setup? Or is your arcanist install old and un-updated? That is, even w/o git-arc.sh, I see color for 'arc list' but not for 'arc list | more'. I'd kinda like to test things with and without the change, though. I'll prep a commit that just drops the ANSI-color filter, but if arc list no longer does that for pipes it won't change anything (I think that was the change that I was talking about back in May). Warner --00000000000091d0f6060efefa28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey John,

On Mon, Jan 15, 2024 at 9:37= =E2=80=AFAM Warner Losh <imp@bsdimp.co= m> wrote:


On Mon, Jan 15, 2024 at 9:30=E2=80= =AFAM John Baldwin <jhb@freebsd.org> wrote:
On 1/14/24 6:24 PM, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Ddf834e06bbc78c03cb6b35f074ae43673c9ce463<= /a>
>
> commit df834e06bbc78c03cb6b35f074ae43673c9ce463
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2024-01-15 02:22:04 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-01-15 02:23:45 +0000
>
>=C2=A0 =C2=A0 =C2=A0 git-arc: Just strip escape sequences form arc log<= br> >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Just strip escape sequences and Warning: lines fro= m 'arc list' output. I
>=C2=A0 =C2=A0 =C2=A0 upgraded and they changed and git arc list broke. = This restores its
>=C2=A0 =C2=A0 =C2=A0 functionality.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Note: jhb didn't like this, so if others objec= t, I'll fix...
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 markj
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D36553

Namely, it breaks the color output for reviews in different states, so Need= s Review
shows up as purple, Approved as green, etc.=C2=A0 If you find the color out= put useful
you'll have to revert this locally.

Also, your last update in the review said that git arc was no longer broken= for you
back in May implying this commit wasn't needed for git arc to work for = you?

Yes and no. I was mistaken. This c= hange is still needed, but its scope can be reduced.
The trouble = is that it's at the first for the other things I committed and getting = it out of the
way was a pain (I tried). Since I didn't want t= o delay things any further, I went ahead and
committed and though= t I'd fix stuff if there were objections.I'll do that now.

So even w/o my change, I don'= t see the color output for the review states (so I can remove the
general filter I added for color). That's easy enough. but what are yo= u doing to get color in the
current setup? Or is your arcanist in= stall old and un-updated?

That is, even w/o git-ar= c.sh, I see color for 'arc list' but not for 'arc list | more&#= 39;. I'd kinda like to test
things with and without the chang= e, though.

I'll prep a commit that just drops = the ANSI-color filter, but if arc list no longer does that for pipes
<= div>it won't change anything (I think that was the change that I was ta= lking about back in May).

Warner
--00000000000091d0f6060efefa28--