From owner-svn-src-all@freebsd.org Sun Apr 17 02:06:11 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35C37B1012D; Sun, 17 Apr 2016 02:06:11 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 06B571BB0; Sun, 17 Apr 2016 02:06:10 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u3H26A8Q021509; Sun, 17 Apr 2016 02:06:10 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u3H26A0w021508; Sun, 17 Apr 2016 02:06:10 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201604170206.u3H26A0w021508@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Sun, 17 Apr 2016 02:06:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r298137 - head/sys/cam/ata X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2016 02:06:11 -0000 Author: imp Date: Sun Apr 17 02:06:10 2016 New Revision: 298137 URL: https://svnweb.freebsd.org/changeset/base/298137 Log: Dell has an OEM drive from Samsung that has issues. NCQ Trim isn't broken on this drive, but it doesn't support it and the fallback logic is failing. Quirk it until those issues can be resolved in a more generic way. Modified: head/sys/cam/ata/ata_da.c Modified: head/sys/cam/ata/ata_da.c ============================================================================== --- head/sys/cam/ata/ata_da.c Sun Apr 17 02:05:45 2016 (r298136) +++ head/sys/cam/ata/ata_da.c Sun Apr 17 02:06:10 2016 (r298137) @@ -588,6 +588,15 @@ static struct ada_quirk_entry ada_quirk_ }, { /* + * Samsung PM851 Series SSDs Dell OEM + * device model "SAMSUNG SSD PM851 mSATA 256GB" + * 4k optimised, NCQ broken + */ + { T_DIRECT, SIP_MEDIA_FIXED, "*", "SAMSUNG SSD PM851*", "*" }, + /*quirks*/ADA_Q_4K | ADA_Q_NCQ_TRIM_BROKEN + }, + { + /* * SuperTalent TeraDrive CT SSDs * 4k optimised & trim only works in 4k requests + 4k aligned */