From owner-svn-ports-all@freebsd.org Wed Nov 7 12:30:57 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E31611125B88; Wed, 7 Nov 2018 12:30:56 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CE4FF8F167; Wed, 7 Nov 2018 12:30:55 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 42qm3X5SzNzDhFd; Wed, 7 Nov 2018 12:30:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id eKwgmxnijCC9; Wed, 7 Nov 2018 12:30:46 +0000 (UTC) Received: from garnet.daemonic.se (host-90-236-10-204.mobileonline.telia.com [90.236.10.204]) by mail.daemonic.se (Postfix) with ESMTPSA id 42qm3T43KdzDj3M; Wed, 7 Nov 2018 12:30:44 +0000 (UTC) Subject: Re: svn commit: r484357 - head/mail/spamassassin To: Baptiste Daroussin , Alexey Dokuchaev Cc: Koichiro Iwao , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201811062146.wA6LknN3005274@repo.freebsd.org> <20181107083105.55o52urafcgdthec@ivaldir.net> <20181107091004.xbvzfyviyrkcbi2m@icepick.vmeta.jp> <20181107092211.dgcvichyunbss35x@ivaldir.net> <2b3670de-7625-d458-7c93-5ea0a7ae2af1@freebsd.org> <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp> <20181107101513.GA81078@FreeBSD.org> <20181107121217.p5ira4vn556t4t2z@ivaldir.net> From: Niclas Zeising Message-ID: Date: Wed, 7 Nov 2018 13:30:43 +0100 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <20181107121217.p5ira4vn556t4t2z@ivaldir.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CE4FF8F167 X-Spamd-Result: default: False [-103.80 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-0.69)[asn: 36236(-3.37), country: US(-0.09)]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[204.10.236.90.zen.spamhaus.org : 127.0.0.11] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 12:30:57 -0000 On 11/7/18 1:12 PM, Baptiste Daroussin wrote: > On Wed, Nov 07, 2018 at 10:15:13AM +0000, Alexey Dokuchaev wrote: >> On Wed, Nov 07, 2018 at 06:55:28PM +0900, Koichiro Iwao wrote: >>> ... >>> +1 to single port. I concern about not all people need that patch. Can >>> FLAVORS be used to create packages with/without Japanese patches? >>> I know it can be used to handle multiple versions of PHP, Python, etc. >> >> There's nothing wrong with a patch not being *useful* to all people, >> the question is would it break anything for anyone. If there are no >> undesired side effects just commit it without hiding it behind options >> or flavors. >> >> ./danfe > > I agree with danfe here! if needed we can in the end play with flavors yes, > but if the patch does not break things to anyone and brings good for japanese > people let's just have the patch in and no options/flavors :) > I need to check with the author of that patch set if there is a reason it's not included in mainline spamassassin. In the meantime, can someone please try to translate the installation instructions for me, as found here: https://github.com/heartbeatsjp/spamassassin_ja/blob/master/docs/installation.md Thanks -- Niclas Zeising