From owner-svn-ports-head@FreeBSD.ORG Fri May 8 18:15:05 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EF46D17D; Fri, 8 May 2015 18:15:04 +0000 (UTC) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "ca.infracaninophile.co.uk" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6BCF61DBD; Fri, 8 May 2015 18:15:04 +0000 (UTC) Received: from zero-gravitas.local (vpn-1.adestra.com [46.236.37.122]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.15.1/8.15.1) with ESMTPSA id t48IAveZ024711 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 May 2015 19:10:59 +0100 (BST) (envelope-from matthew@FreeBSD.org) Authentication-Results: smtp.infracaninophile.co.uk; dmarc=none header.from=FreeBSD.org DKIM-Filter: OpenDKIM Filter v2.9.2 smtp.infracaninophile.co.uk t48IAveZ024711 Authentication-Results: smtp.infracaninophile.co.uk/t48IAveZ024711; dkim=none reason="no signature"; dkim-adsp=none; dkim-atps=neutral X-Authentication-Warning: lucid-nonsense.infracaninophile.co.uk: Host vpn-1.adestra.com [46.236.37.122] claimed to be zero-gravitas.local Message-ID: <554CFC24.6020605@FreeBSD.org> Date: Fri, 08 May 2015 19:10:44 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Bryan Drewery , Sunpoet Po-Chuan Hsieh CC: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385776 - in head/sysutils: . rubygem-hiera-file References: <201505081305.t48D5ULi055835@svn.freebsd.org> <554CD6C9.5000708@FreeBSD.org> <554CDBE8.7020703@FreeBSD.org> In-Reply-To: <554CDBE8.7020703@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6gUTTpaT06qLHrUl0LCN8hkeca8EJgbn0" X-Virus-Scanned: clamav-milter 0.98.6 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2015 18:15:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6gUTTpaT06qLHrUl0LCN8hkeca8EJgbn0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2015/05/08 16:53, Bryan Drewery wrote: > On 5/8/2015 10:43 AM, Sunpoet Po-Chuan Hsieh wrote: >> On Fri, May 8, 2015 at 11:31 PM, Bryan Drewery > > wrote: >> >> On 5/8/2015 9:45 AM, Sunpoet Po-Chuan Hsieh wrote: >> > On Fri, May 8, 2015 at 9:05 PM, Matthew Seaman >> > >> wrote= : >> > >> > Author: matthew >> > Date: Fri May 8 13:05:29 2015 >> > New Revision: 385776 >> > URL: https://svnweb.freebsd.org/changeset/ports/385776 >> > >> > Log: >> > A data backend for Hiera that can return the content of >> whole files. >> > >> > WWW: https://github.com/adrienthebo/hiera-file >> > >> > Added: >> > head/sysutils/rubygem-hiera-file/ >> > head/sysutils/rubygem-hiera-file/Makefile (contents, pro= ps >> changed) >> > head/sysutils/rubygem-hiera-file/distinfo (contents, pro= ps >> changed) >> > head/sysutils/rubygem-hiera-file/pkg-descr (contents, >> props changed) >> > Modified: >> > head/sysutils/Makefile >> > >> > Modified: head/sysutils/Makefile >> > =20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> > --- head/sysutils/Makefile Fri May 8 13:02:39 2015 >> > (r385775) >> > +++ head/sysutils/Makefile Fri May 8 13:05:29 2015 >> > (r385776) >> > @@ -836,6 +836,7 @@ >> > SUBDIR +=3D rubygem-hammer_cli_foreman_salt >> > SUBDIR +=3D rubygem-hammer_cli_foreman_ssh >> > SUBDIR +=3D rubygem-hiera >> > + SUBDIR +=3D rubygem-hiera-file >> > SUBDIR +=3D rubygem-librarian-puppet >> > SUBDIR +=3D rubygem-log4r >> > SUBDIR +=3D rubygem-logify >> > >> > Added: head/sysutils/rubygem-hiera-file/Makefile >> > =20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> > --- /dev/null 00:00:00 1970 (empty, because file is newl= y >> added) >> > +++ head/sysutils/rubygem-hiera-file/Makefile Fri May 8 >> 13:05:29 >> > 2015 (r385776) >> > @@ -0,0 +1,18 @@ >> > +# Created by: Matthew Seaman >> > +# $FreeBSD$ >> > + >> > +PORTNAME=3D hiera-file >> > +PORTVERSION=3D 1.1.1 >> > +CATEGORIES=3D sysutils rubygems >> > +MASTER_SITES=3D RG >> > + >> > +MAINTAINER=3D matthew@FreeBSD.org >> > +COMMENT=3D Data backend for Hiera that returns whole = files >> > + >> > +USE_RUBY=3D yes >> > +USE_RUBYGEMS=3D yes >> > +RUBYGEM_AUTOPLIST=3D yes >> > + >> > +RUN_DEPENDS=3D >> > ${PKGNAMEPREFIX}hiera>=3D0:${PORTSDIR}/sysutils/rubygem-hie= ra >> > >> > >> > RUN_DEPENDS should appear earlier. :) >> > >> >> Why? >> >> >> % portlint -abct >> WARN: Makefile: Consider defining LICENSE. >> WARN: Makefile: "RUN_DEPENDS" has to appear earlier. >> 0 fatal errors and 2 warnings found. >=20 > This rule serves no purpose. The port was pretty much cut'n'paste from sysutils/rubygem-hiera. Besides, where in the Makefile would be considered suitable by portlint? Above all the USE_FOO=3D stuff? That's going to generate even worse complaints. Oh, I get it. It thinks the RUBYGEM_AUTOPLIST line should occur later. Except that the rational place to put that is right next to the 'USE_RUBYGEMS' line. portlint isn't guarranteed to be perfect, and in this case, I think it is complaining unnecessarily. Cheers, Matthew --6gUTTpaT06qLHrUl0LCN8hkeca8EJgbn0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - https://gpgtools.org iQJ8BAEBCgBmBQJVTPwrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxOUYxNTRFQ0JGMTEyRTUwNTQ0RTNGMzAw MDUxM0YxMEUwQTlFNEU3AAoJEABRPxDgqeTn/noP/3PBevlkLAXoYodT3SvWxE5M KvYPVpva3GjnS+z+h7NjWd2UWb5nMQTD9lAJMQ4u9tLAB3RZr1xgz3PeBc09SMSm KtN/QyYXR7HLB5Q1H/G6sMkuw/Ua7+r6KoZHzOnYa+uYgGC//dk3RdTHgbPw+6hO ar9oQdoZAScAb7I+3uSrL+AJoR11cjMyUqoUbn3RvDIAEYS5jX09QXH0diHTk7Mh EVt/tpupccHQAZ8D11zHPv4J3tZxyPLo7fcBNIP5QDX6Oeb70y3/kz6PAVLpqAfr 8vwpC/id7W/NEXnHl/NyAVXVY/bL2+POgAv4YJX873Tsr+D1tiMCv6BPpdf9IltL SmtrIBsMPUDcV7Hb+Sx/CeZajW4iJCNjXgfpkPauyVNPvLnYhsFgvlthDDVhmXMF RcxB/lhop9jbO6Mr9W1noy/x+hgUvIQ3DFstf9RWbC7dHR6Tttg975o3N6SI5fFi jjtu1w87+9+xWF8rxNgBo4/9DkGhMWRufGn1yWwz9aKi5HStXV37483yN41w2MGc xeS/4nV8rYMJOwpS9e20g2jFs0LeT/Q/b8VagBY0037Ssxiq2VoLyQybXFm/OD6B tIeGKNk3e8YNGsJsd6USb6lqkp1KsJA2lTyEJri5zyTvQtxqA1Ps/CZuzkMMvoe8 m5WjnSYwJ1X/wBhxl4OH =5Eid -----END PGP SIGNATURE----- --6gUTTpaT06qLHrUl0LCN8hkeca8EJgbn0--