From owner-freebsd-arm@FreeBSD.ORG  Sat Feb  2 17:57:13 2008
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0734416A420
	for <arm@freebsd.org>; Sat,  2 Feb 2008 17:57:13 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (dong.ci0.org [IPv6:2001:7a8:2066:1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 2872C13C45B
	for <arm@freebsd.org>; Sat,  2 Feb 2008 17:57:11 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.14.1/8.13.8) with ESMTP id m12J9YmY018117;
	Sat, 2 Feb 2008 20:09:34 +0100 (CET)
	(envelope-from mlfbsd@dong.ci0.org)
Received: (from mlfbsd@localhost)
	by dong.ci0.org (8.14.1/8.13.8/Submit) id m12J9Y2F018114;
	Sat, 2 Feb 2008 20:09:34 +0100 (CET) (envelope-from mlfbsd)
Date: Sat, 2 Feb 2008 20:09:33 +0100
From: Olivier Houchard <mlfbsd@ci0.org>
To: Soeren Straarup <xride@x12.dk>
Message-ID: <20080202190933.GA18088@ci0.org>
References: <20080202090238.289eeb66@x12.dk> <20080202183138.GA17602@ci0.org>
	<20080202185449.6b9068a2@x12.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080202185449.6b9068a2@x12.dk>
User-Agent: Mutt/1.4.1i
Cc: arm@freebsd.org
Subject: Re: about src/lib/libkse/arch/arm/include/pthread_md.h
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Feb 2008 17:57:13 -0000

On Sat, Feb 02, 2008 at 06:54:49PM +0100, Soeren Straarup wrote:
> On Sat, 2 Feb 2008 19:31:38 +0100
> Olivier Houchard <mlfbsd@ci0.org> wrote:
> 
> > Hi Soeren,
> > 
> > On Sat, Feb 02, 2008 at 09:02:38AM +0100, Soeren Straarup wrote:
> > > Hi,
> > > 
> > > Index: pthread_md.h
> > > ===================================================================
> > > RCS file: /home/ncvs/src/lib/libkse/arch/arm/include/pthread_md.h,v
> > > retrieving revision 1.9
> > > diff -u -r1.9 pthread_md.h
> > > --- pthread_md.h        9 Oct 2007 13:42:23 -0000       1.9
> > > +++ pthread_md.h        1 Feb 2008 22:48:50 -0000
> > > @@ -240,7 +240,7 @@
> > >                 tcb->tcb_tmbx.tm_lwp = kcb->kcb_kmbx.km_lwp;
> > >                 if (setmbox)
> > >                         _thr_setcontext(mc,
> > > (intptr_t)&tcb->tcb_tmbx,
> > > -                               (intptr_t
> > > *)&kcb->kcb_kmbx.km_curthread);
> > > +                               (intptr_t
> > > *)kcb->kcb_kmbx.km_curthread); else
> > >                         _thr_setcontext(mc, 0, NULL);
> > >         } else {
> > > 
> > > 
> > > Is that change correct?
> > > 
> > 
> > If I'm nor wrong, the original code is right, and that's what the
> > other platforms seem to do so. Why do you think it should be changed ?
> > 
> 
> Due to that if gcc is run with warnings set as errors it breaks.
> 

We probably should do what other platforms do, and cast it to (void *)
before (intptr_t *).
Wanna commit it, or shall I ?

Olivier