From nobody Fri Jul 31 11:56:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBPg14zhnz6mcyc for ; Fri, 31 Jul 2026 11:56:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBPg13LR5z3GGZ for ; Fri, 31 Jul 2026 11:56:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785498989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U5EeqGDt/PyQ+HgUXNmCQZ4KRs1rI3g0Zy4XxMcltEQ=; b=qSrZQknWOF6ILJnP2ofXq1F/WWbwQgsSs8TGpGx+QdDg7P0VtTNZaFcTbZOkphMSQZs9Ab 24ruz1tth+vQWOKVEyuFlzFnr/Mv8MPO5YQWOBdzsJi86yXAYvZcg3yvBAjlgKq8kIFfk5 Vqi/hoMJMkzfYbVAjmsbeBs5Rtm/3tmnI6Vw7cdV3Ub7j78/5/eNhou0fnQsBjkP5VNTwI gNB0Ekaclxo09EdUzqjHkXF/RW/vbw/5+N6fhjfrCq6n68ttrw0fOG3SDZl++2GSTM5RLn TMEVcVcfVu7GQ2aWuNAQC01dK68L155os0rxQtXwcp2PNMtyOlbQ4W2+av4aBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785498989; a=rsa-sha256; cv=none; b=S7S3229rh0lCAw5RQFi1aoTHsxR/iuKKYjBiEDfNgDpPjzarXGveq1XPvedYn5Zmtjpugq pzkU3iIa0aeXdoVe+qhFA8szU8eCz8M77D69gZGzShMSF4P0b0yeRZrjHJsQJ0eWDa0A+e S0tGo4Z2+a3yqZE5oTO+TnoFjK/SXh2KMxtUajKzAEF0sMRn4GMoAsTfAGsT+Sle/5Qy8H Ztw/PvoUIFvkSlI6lsYj7aA2H634YTCvBXuvLBPY6CQC2Nckfx2rfUyJqkZNudC5b4mvJd Sk3r6q+vrYrfAwyXkTkJPtNInq/xt68KwW7LNsajPelu2jdVIRM05q3/S4IJtA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785498989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U5EeqGDt/PyQ+HgUXNmCQZ4KRs1rI3g0Zy4XxMcltEQ=; b=C/t0hO53+KAyaLyXZT+OS5DNjVH3uSDLn0K9RYfckuivsgfv2kYokgZZrBxVZsF8o60wvt SRr8WLCZk80jVOh/4wFILb8rBz2RlADuQ5oQEouxQokY0knW0vy8kw9F9pTqyfZeKxGK5p ICEHHmO4FDDEZrz5qjXdBKctMkyJg267NCZA5NnjLsaIQhA3qwP3vw+yB8VBahSRSVemZu iLd9sfttdww72RSVtgkyzmWsaFVEKCyGHSSzXSbsLuuC3pg2+TmMPArn2EpbC/u7irKMwg D4e4UC0iFR4l2THLYXE30OD1bsUM6sGchnfuyEK01Lhs4V/vJMVObYDGE1IrtQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBPg11B4yzyFn for ; Fri, 31 Jul 2026 11:56:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40f7c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 11:56:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: db2bf4553ce3 - main - ixgbe: fix host interface timeout detection List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: db2bf4553ce32fdcae00f6e7392a6c2010247dd6 Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 11:56:23 +0000 Message-Id: <6a6c8d67.40f7c.1a425520@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=db2bf4553ce32fdcae00f6e7392a6c2010247dd6 commit db2bf4553ce32fdcae00f6e7392a6c2010247dd6 Author: Kevin Bowling AuthorDate: 2026-07-28 11:21:14 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 11:55:39 +0000 ixgbe: fix host interface timeout detection The host-interface polling loop was scaled from milliseconds to microseconds, but its terminal test was left using the unscaled timeout. Completion at that intermediate iteration can be reported as a timeout, while actual expiry is not recognized and can accept stale status. Test against the scaled loop bound used by the polling loop. Fixes: f46d75c90f5f ("ixgbe: improve MDIO performance by reducing semaphore/IPC delays") MFC after: 1 week --- sys/dev/ixgbe/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/ixgbe_common.c b/sys/dev/ixgbe/ixgbe_common.c index 0b6bf728f25e..ab763595f0b5 100644 --- a/sys/dev/ixgbe/ixgbe_common.c +++ b/sys/dev/ixgbe/ixgbe_common.c @@ -4646,7 +4646,7 @@ s32 ixgbe_hic_unlocked(struct ixgbe_hw *hw, u32 *buffer, u32 length, return IXGBE_SUCCESS; /* Check command completion */ - if ((timeout && i == timeout) || + if ((timeout && i == timeout * 1000) || !(IXGBE_READ_REG(hw, IXGBE_HICR) & IXGBE_HICR_SV)) { ERROR_REPORT1(IXGBE_ERROR_CAUTION, "Command has failed with no status valid.\n");