From owner-freebsd-current@freebsd.org Fri Jun 15 20:53:56 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC0BD101BD06; Fri, 15 Jun 2018 20:53:56 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670051.outbound.protection.outlook.com [40.107.67.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F11F82987; Fri, 15 Jun 2018 20:53:53 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM (52.132.44.24) by YTOPR0101MB0748.CANPRD01.PROD.OUTLOOK.COM (52.132.43.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.18; Fri, 15 Jun 2018 20:53:52 +0000 Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::d0eb:3783:7c99:2802]) by YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::d0eb:3783:7c99:2802%3]) with mapi id 15.20.0863.016; Fri, 15 Jun 2018 20:53:52 +0000 From: Rick Macklem To: "rc@freebsd.org" , "freebsd-current@freebsd.org" Subject: review of nfsd rc.d script patch Thread-Topic: review of nfsd rc.d script patch Thread-Index: AQHUBOpJU2qX1eyBDUe5qiTFuEQ6Ag== Date: Fri, 15 Jun 2018 20:53:52 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB0748; 7:HLWJbEgKAE/oPjaqP8g/X8xpoJ+zSFEMAjRqVkftvSDtGgZxVJKlUHW207C55n/YBOOhoVYdJNeT8jwnozAAHtG7LnnPs5Flq5OcqRXFs5GphuwOeJlnx1vAiwGoKYfGeSfr61gPmLLMgHG+byMUKeUDvtwmpo2dUrkOu5SiAMmJNQzWMj6Nr2NyquheD9pwIvg/4sNTCw7ofLDYg5E5d0P5WEhEqWLh+KCKPMy0WiYmk7lUPtUYMaJSm3ViCBUM x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 65883a6f-1ea1-44e0-ca34-08d5d30219e1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989080)(5600026)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB0748; x-ms-traffictypediagnostic: YTOPR0101MB0748: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(150554046322364); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:YTOPR0101MB0748; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB0748; x-forefront-prvs: 0704670F76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(39380400002)(366004)(346002)(376002)(189003)(199004)(51444003)(476003)(6506007)(7696005)(786003)(2900100001)(186003)(2906002)(99286004)(26005)(486006)(9686003)(3280700002)(316002)(102836004)(86362001)(2501003)(105586002)(106356001)(5250100002)(3660700001)(97736004)(14454004)(6436002)(55016002)(478600001)(305945005)(74316002)(8936002)(53936002)(450100002)(8676002)(5660300001)(25786009)(68736007)(81166006)(81156014)(33656002)(110136005)(74482002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB0748; H:YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: O3LgGf/XUIGPNsTn+lRz4dvDY5d5U0wxBIEKvaf0n7qiDWA3Mr6lLPYYfqyDIqbNLzfu6tHQU914SRBVephegujr8ZWNiUPwcBu0sw5po+Aao9EltPZmR4mJmQ3gwMvAsyDdFm79wUWKABb41xph5UKeqKaMK+eZg0BtRDfCMSm6lPH/xOL6nevycqrLxWLZ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 65883a6f-1ea1-44e0-ca34-08d5d30219e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2018 20:53:52.0103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB0748 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 20:53:57 -0000 Hi, For the pNFS service MDS machine, the nfsd can't be started until all nfs m= ounts in /etc/fstab are done. I think that adding "mountcritremote" to the "# REQUIRE:" line is sufficien= t to do this? I don't think delaying the startup of the nfsd daemon until after any NFS m= ounts are done will do any harm, but if others think it would be a POLA violation= , I could make this dependent on the pNFS service being enabled. Does anyone think this would cause a POLA violation? If someone familiar with the rc scripts could review this little patch, it = would be appreciated: --- nfsd.old 2018-06-15 16:07:54.279786000 -0400 +++ nfsd 2018-06-15 16:08:43.934603000 -0400 @@ -4,7 +4,7 @@ # =20 # PROVIDE: nfsd -# REQUIRE: mountd hostname gssd nfsuserd +# REQUIRE: mountcritremote mountd hostname gssd nfsuserd # KEYWORD: nojail shutdown =20 . /etc/rc.subr Thanks, rick