From owner-svn-src-head@FreeBSD.ORG  Sun Aug  5 17:53:58 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C59031065670;
	Sun,  5 Aug 2012 17:53:58 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.95.76.21])
	by mx1.freebsd.org (Postfix) with ESMTP id 9EC3A8FC15;
	Sun,  5 Aug 2012 17:53:58 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.5/8.14.5) with ESMTP id
	q75Hrw9v050033; Sun, 5 Aug 2012 10:53:58 -0700 (PDT)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.5/8.14.5/Submit) id
	q75HrwxT050032; Sun, 5 Aug 2012 10:53:58 -0700 (PDT)
	(envelope-from sgk)
Date: Sun, 5 Aug 2012 10:53:57 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Dimitry Andric <dim@FreeBSD.org>
Message-ID: <20120805175357.GA50024@troutmask.apl.washington.edu>
References: <201208051723.q75HNl80006961@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201208051723.q75HNl80006961@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r239074 - head/usr.sbin/ctladm
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Aug 2012 17:53:58 -0000

On Sun, Aug 05, 2012 at 05:23:47PM +0000, Dimitry Andric wrote:
> Author: dim
> Date: Sun Aug  5 17:23:47 2012
> New Revision: 239074
> URL: http://svn.freebsd.org/changeset/base/239074
> 
> Log:
>   In usr.sbin/ctladm/ctladm.c, function cctl_error_inject(), initialize
>   the 'retval' variable to zero, to avoid returning garbage in several
>   cases.
>   
>   This fixes the following clang 3.2 warnings:
>   
>     usr.sbin/ctladm/ctladm.c:1234:6: error: variable 'retval' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>             if (ioctl(fd, CTL_ERROR_INJECT, &err_desc) == -1) {
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Dimitry can you wrap these long error messages to something
shorter than 80 characters.  The commit messages are otherwise
pain to read.

-- 
Steve