From owner-freebsd-bugs@FreeBSD.ORG  Mon Aug  7 21:38:08 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@FreeBSD.org
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0ABC916A4E0;
	Mon,  7 Aug 2006 21:38:08 +0000 (UTC) (envelope-from bde@zeta.org.au)
Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C6E2B43D6D;
	Mon,  7 Aug 2006 21:38:06 +0000 (GMT) (envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.2.162])
	by mailout2.pacific.net.au (Postfix) with ESMTP id 88E5610D076;
	Tue,  8 Aug 2006 07:38:05 +1000 (EST)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3sarge1) with ESMTP
	id k77Lc3wj016899; Tue, 8 Aug 2006 07:38:04 +1000
Date: Tue, 8 Aug 2006 07:38:03 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@delplex.bde.org
To: Dan Nelson <dnelson@allantgroup.com>
In-Reply-To: <200608071659.k77GxGTA014220@dan.emsphone.com>
Message-ID: <20060808071623.F9516@delplex.bde.org>
References: <200608071659.k77GxGTA014220@dan.emsphone.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/101590: -O2 optimizing out abi-tag note from executables
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Aug 2006 21:38:08 -0000

On Mon, 7 Aug 2006, Dan Nelson wrote:

>> Fix:
>
> Mark abitag as __used instead of __unused, which will force gcc to
> leave the symbol in the resulting object file even though it's static
> and has no references.

"__used" is misspelled "__unused" in several other places.  "__used" is new
so it is rarely used.  "__unused" had to be used bogusly to prevent warnings
about things that are used but which the compiler couldn't see are used,
but now the correct spelling can be used.

"__used" is now defined in <sys/cdefs.h>, but <sys/cdefs.h> doesn't
actually use it.  E.g., <sys/cdefs.h still uses "__unused" for __IDSTRING(),
but only in the non-__GNUC__ case which is broken anyway due to related
bugs (some header files use __aligned(), but __aligned is intentionally
left undefined to properly break the non-__GNUC__ case).  The usual case
of __IDSTRING() (and thus __FBSDID()) apparently works because the usedness
is hidden in an asm statement.

crtbrand.c hard-codes the gccism __attribute((...__[un]used)) instead
of using the macro __[un]used defined in <sys/cdefs.h>.  This is almost
correct, since crtbrand.c needs to use more attributes than <sys/cdefs.h>
can reasonably define.

Bruce