From owner-svn-src-head@freebsd.org  Thu Sep  6 13:56:56 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56D91FFC060;
 Thu,  6 Sep 2018 13:56:56 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 116EC78082;
 Thu,  6 Sep 2018 13:56:56 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0A2A4E554; Thu,  6 Sep 2018 13:56:56 +0000 (UTC)
Date: Thu, 6 Sep 2018 13:56:56 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Konstantin Belousov <kib@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r337773 - in head/sys/amd64: amd64 include
Message-ID: <20180906135656.GA28635@FreeBSD.org>
References: <201808141637.w7EGbFpZ087559@repo.freebsd.org>
 <20180815084503.GA96451@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180815084503.GA96451@FreeBSD.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 13:56:56 -0000

On Wed, Aug 15, 2018 at 08:45:04AM +0000, Alexey Dokuchaev wrote:
> On Tue, Aug 14, 2018 at 04:37:15PM +0000, Konstantin Belousov wrote:
> > New Revision: 337773
> > URL: https://svnweb.freebsd.org/changeset/base/337773
> > 
> > Log:
> >   amd64: ensure that curproc->p_vmspace pmap always matches PCPU
> >   curpmap.
> >   
> >   When performing context switch on a machine without PCID, if current
> >   %cr3 equals to the new pmap %cr3, which is typical for kernel_pmap
> >   vs. kernel process, I overlooked to update PCPU curpmap value.  Remove
> >   check for %cr3 not equal to pm_cr3 for doing the update.  It is
> >   believed that this case cannot happen at all, due to other changes in
> >   this revision.
> > ...
> > -	} else if (cr3 != pmap->pm_cr3) {
> > +	} else {
> >  		load_cr3(pmap->pm_cr3);
> 
> If this case cannot happen at all, would it make sense to assert it?

Did I miss your reply on this one?

./danfe