Date: Thu, 9 Dec 2010 10:15:44 +0000 From: Chris Rees <utisoft@gmail.com> To: Sahil Tandon <sahil@freebsd.org> Cc: dinoex@freebsd.org, ports@freebsd.org, Rick <rick@lgarchitecture.com> Subject: Re: FreeBSD Port: ngircd-0.15 Message-ID: <AANLkTika2YuWp528h2z5y7ESZ9NM7UdGngUiCubvC9XW@mail.gmail.com> In-Reply-To: <20101209002438.GB35076@magic.hamla.org> References: <4CFEA151.8010708@lgarchitecture.com> <AANLkTimRrHHPJMn-sS6P4rrJFPos8r5h-_cLKZ65teP2@mail.gmail.com> <20101209002438.GB35076@magic.hamla.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 December 2010 00:24, Sahil Tandon <sahil@freebsd.org> wrote:
> On Wed, 2010-12-08 at 14:39:42 +0000, Chris Rees wrote:
>
>> On 7 December 2010 21:04, Rick <rick@lgarchitecture.com> wrote:
>> > Hello,
>> >
>> > Here's an update for the irc/ngircd port from v0.15 to the latest stab=
le
>> > v0.17.
>> >
>> > Thanks,
>> > Rick
>> >
>>
>> I would perhaps include:
>>
>> -DISTNAME=3D =A0 =A0${PORTNAME}-17
>> +DISTVERSION=3D ${PORTVERSION:C/0.//1}
>>
>> negating the need to fiddle with DISTNAME after each upgrade.
>
> This works and I see it has already been committed, but it seems
> overkill to use an extended regular expressions in this situation. =A0A
> simple string replacement (using the 'S' instead of 'C' modifier) would
> suffice:
>
> DISTVERSION=3D =A0 =A0${PORTVERSION:S/0.//}
>
Of course, sorry I was just doing it off the top of my head.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTika2YuWp528h2z5y7ESZ9NM7UdGngUiCubvC9XW>