From owner-svn-src-all@freebsd.org Sun May 15 16:46:01 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46B14B3C70E for ; Sun, 15 May 2016 16:46:01 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0BAD11D0B for ; Sun, 15 May 2016 16:46:00 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 8cd5ed74-1abc-11e6-9de8-1b78d5a2543b X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Sun, 15 May 2016 16:46:19 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u4FGjvcB045039; Sun, 15 May 2016 10:45:57 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1463330757.1180.154.camel@freebsd.org> Subject: Re: svn commit: r299839 - head/etc/rc.d From: Ian Lepore To: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 15 May 2016 10:45:57 -0600 In-Reply-To: <201605150438.u4F4coNR080598@repo.freebsd.org> References: <201605150438.u4F4coNR080598@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2016 16:46:01 -0000 On Sun, 2016-05-15 at 04:38 +0000, Garrett Cooper wrote: > Author: ngie > Date: Sun May 15 04:38:50 2016 > New Revision: 299839 > URL: https://svnweb.freebsd.org/changeset/base/299839 > > Log: > Make FILESYSTEMS, dumpon, and var not depend on zfs and zvol > > Make zfs and zvol come before all of the items that depended on > them > previously > I'm trying to figure out why these changes are needed. rcorder works just fine when a requirement has no providers (yes, it whines, but that's why /etc/rc invokes it with 2>/dev/null). If FILESYSTEMS requires zfs and nothing provides zfs, then it's as if the requirement weren't in the list at all. The manpage for rcorder is wrong, the DIAGNOSTICS section implies that rcorder will abort on a missing requirement, but it doesn't. Changing requirements to BEFOREs seems like it has a lot of potential for messing with peoples' out-of-tree customizations. (And for some reason I've always had the impression that BEFORE was to be avoided in the base rc files, but I can't remember why I think that.) -- Ian