Date: Mon, 8 Mar 2010 09:47:57 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: Alexander Best <alexbestms@wwu.de>, Ulrich =?iso-8859-1?q?Sp=F6rlein?= <uqs@spoerlein.net>, Xin LI <delphij@delphij.net> Subject: Re: tiny lib/libkvm/kvm_proc.c correction Message-ID: <201003080947.58027.jhb@freebsd.org> In-Reply-To: <20100306083916.GI21344@acme.spoerlein.net> References: <permail-20100305195910f0889e8400000ee3-a_best01@message-id.uni-muenster.de> <4B916BD0.7030501@delphij.net> <20100306083916.GI21344@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 06 March 2010 3:39:17 am Ulrich Sp=F6rlein wrote: > On Fri, 05.03.2010 at 12:38:40 -0800, Xin LI wrote: > > On 2010/03/05 11:59, Alexander Best wrote: > > > Xin LI schrieb am 2010-03-05: > > > On 2010/03/05 11:26, Alexander Best wrote: > > >>>> hi there. does this look right? > > >=20 > > > Not to me, the value is not to be used this way and the comments > > > above the code explained the same thing. > > >=20 > > > I think we should use cputick2usec but it's not available to userland > > > (one have to copy cpu_tick_frequency and friends). > > >=20 > > >> damn you're right. i completely overlooked that comment. would it be= =20 worth > > >> making cputick2usec available to userland? is kvm_proc.c the only=20 candidate in > > >> need of converting cpu ticks to usecs? > >=20 > > I'm not sure how to do that unfortunately, is there a way to expose a > > kernel variable to userland which also works on a crash dump? >=20 > ticks *is* available to libkvm, not sure what happens on crashdumps, > though. The following patchset has not been tested: >=20 >=20 https://www.spoerlein.net/gitweb/?p=3Dfreebsd.work/.git;a=3Dcommitdiff;h=3D= d500a051eb75dd234166bb11485c0a953aefce1d I'm fine with this patch so long as you are reading 'ticks' from the crash= =20 dump. =2D-=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003080947.58027.jhb>