From owner-p4-projects@FreeBSD.ORG  Tue May 11 00:04:08 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6688F1065674; Tue, 11 May 2010 00:04:08 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2B28D1065672
	for <perforce@freebsd.org>; Tue, 11 May 2010 00:04:08 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe02.swip.net [212.247.154.33])
	by mx1.freebsd.org (Postfix) with ESMTP id AE1C28FC12
	for <perforce@freebsd.org>; Tue, 11 May 2010 00:04:07 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=qL1Cqo4YLXoA:10 a=Q9fys5e9bTEA:10
	a=M8b_wTzEtboA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17
	a=o1ClsfTC3BFJSMjbj2MA:9 a=AGp1dEPD4qV1btnhOEw0VE-rYb4A:4
	a=PUjeQqilurYA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 1376145741 for perforce@freebsd.org;
	Tue, 11 May 2010 02:04:05 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Perforce Change Reviews <perforce@freebsd.org>
Date: Tue, 11 May 2010 02:01:19 +0200
User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; )
References: <201005102335.o4ANZnb9090023@repoman.freebsd.org>
In-Reply-To: <201005102335.o4ANZnb9090023@repoman.freebsd.org>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(
	=?iso-8859-1?q?=3B=5FIjlA=3A=0A=09hGE=2E=2EEw?=,
	=?iso-8859-1?q?XAQ*o=23=5C/M=7ESC=3DS1-f9=7BEzRfT=27=7CHhll5Q=5Dha5Bt-s=7Co?=
	=?iso-8859-1?q?TlKMusi=3A1e=5BwJl=7Dkd=7DGR=0A=09Z0adGx-x=5F0zGbZj=27e?=(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201005110201.19384.hselasky@c2i.net>
Cc: 
Subject: Re: PERFORCE change 178075 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 May 2010 00:04:08 -0000

On Tuesday 11 May 2010 01:35:49 Hans Petter Selasky wrote:
>                 usb_hub.c:
>         
>                 - overload the "bandwidth_reclaimed" bit-flag, which should
>                   only be used for the UHCI. When used with the EHCI it
>  means we have allocated bandwidth for a high speed endpoint. This bit is
>  checked when allocating and freeing to avoid duplicate operations. At
>  least the close method of a USB transfer type can be called two times in a
>  row, with only one open, due to the current design.
> 

s/close/xxx_device_done/

Close should always be paired with open. What I had in mind was the 
ehci_device_done() method, which can be called multiple times. And hence 
neither of any allocations/freeing is done from that function, the double-call 
check can be removed (is superfluous)

--HPS