From owner-cvs-all@FreeBSD.ORG  Thu Nov 13 01:04:25 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7B08816A4F1; Thu, 13 Nov 2003 01:04:25 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B4CAE43F3F; Thu, 13 Nov 2003 01:04:24 -0800 (PST)
	(envelope-from marcel@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hAD94OXJ092179;
	Thu, 13 Nov 2003 01:04:24 -0800 (PST)
	(envelope-from marcel@repoman.freebsd.org)
Received: (from marcel@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hAD94Oms092178;
	Thu, 13 Nov 2003 01:04:24 -0800 (PST)
	(envelope-from marcel)
Message-Id: <200311130904.hAD94Oms092178@repoman.freebsd.org>
From: Marcel Moolenaar <marcel@FreeBSD.org>
Date: Thu, 13 Nov 2003 01:04:24 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/usr.bin/truss syscalls.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2003 09:04:25 -0000

marcel      2003/11/13 01:04:24 PST

  FreeBSD src repository

  Modified files:
    usr.bin/truss        syscalls.c 
  Log:
  Do not ignore any possible errors that fseeko() may have. The fact
  is that fseeko() fails in very predictable and frequent ways on ia64.
  This is because the offset is actually an address in the process'
  address space, which on ia64 can be larger than long (for lseek) or
  off_t (for fseeko). The crux is the signedness. The register stack
  and memory stack are in region 4 on ia64. This means that the sign bit
  is 1. The large positive virtual address is wrongly interpreted as
  a negative file offset.
  
  There's no quick fix. Even if you get around the API by using a
  SEEK_SET up to LONG_MAX and follow it up with a SEEK_CUR for the
  remainder, the kernel simply cannot deal with it. and the second
  seek will just fail.
  
  Therefore, this change does not actually fix the root cause. It just
  makes sure we're not spitting out all kinds of garbage or that the
  get_struct() function in particular does not cause truss(1) to exit.
  This, I might add, invariably happened way too soon for truss(1) to
  be of any use on ia64...
  
  Revision  Changes    Path
  1.33      +24 -22    src/usr.bin/truss/syscalls.c