Date: Wed, 3 Sep 2014 15:28:26 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Antoine Brodin <antoine@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r367212 - in head: astro/planets devel/aifad ftp/ocaml-ocurl Message-ID: <20140903152826.GA38672@FreeBSD.org> In-Reply-To: <201409031525.s83FPHLO090538@svn.freebsd.org> References: <201409031525.s83FPHLO090538@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 03, 2014 at 03:25:17PM +0000, Antoine Brodin wrote: > New Revision: 367212 > URL: http://svnweb.freebsd.org/changeset/ports/367212 > > Log: > Fix packaging > [...] > > -PORTDOCS= KEYBINDINGS.txt getting_started.html > -PLIST_FILES= bin/planets man/man1/planets.1.gz > - > do-install: > ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin > ${INSTALL_MAN} ${WRKSRC}/planets.1 ${STAGEDIR}${MANPREFIX}/man/man1 > @${MKDIR} ${STAGEDIR}${DOCSDIR} > -.for doc in ${PORTDOCS} > - ${INSTALL_DATA} ${WRKSRC}/${doc} ${STAGEDIR}${DOCSDIR} > -.endfor > + ${INSTALL_DATA} ${WRKSRC}/KEYBINDINGS.txt ${STAGEDIR}${DOCSDIR} > + ${INSTALL_DATA} ${WRKSRC}/getting_started.html ${STAGEDIR}${DOCSDIR} > > [...] > +bin/planets > +man/man1/planets.1.gz > +%%PORTDOCS%%%%DOCSDIR%%/KEYBINDINGS.txt > +%%PORTDOCS%%%%DOCSDIR%%/getting_started.html > +%%PORTDOCS%%@dirrm %%DOCSDIR%% Hey Antoine, can you explain what's going on here? Lots of ports are using PLIST_FILES/PORTDOCS to avoid spamming the tree with little pkg-plist files, and now you're essentially reverting it back. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140903152826.GA38672>