From nobody Wed Dec 21 00:58:18 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NcFRt4pZ6z1G5S1; Wed, 21 Dec 2022 00:58:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NcFRt402Lz3sN7; Wed, 21 Dec 2022 00:58:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671584298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3xb2JFd+oefDasnN7RZ0SFv2ZFS4Mzl0yZbftN/Kozs=; b=uxStj+LJ8GSd0zxbXyvCyww5bnPvTcLwFprBAYWcfgXBGchxpuddG32Rs28j3ePod6XVob 6gzuPQ0M2ZAl1bmVXK1gOJQR+1sHxijro+YBVZWktQ7qVL3uUiU/F1+gj0kBlRSWrl17Gp TaiUROXl88x9jDT1wRWWvHaa1NbBnxhgxBljhWTKlsQu2j/diE9oHFH2RYomUVUd71srwc 83mzc96yoRIQF3fNVS+Pw6hEaXjLIOFNO51KMXO4/52qoT466uEJ8rQa7sleC3hBqjAuuR v1dEmNbSlQQNOhsFlTR+Pj07lseMl5DyDbYI8BIHC05l2cmMooFgkjDAu2dEcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671584298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3xb2JFd+oefDasnN7RZ0SFv2ZFS4Mzl0yZbftN/Kozs=; b=E8H46fGPfWQYw/D2/Fkwqv2IXfVuhRPQTtzvE7RvqFimL8IY2xgGsyDlmJpk1/H97bEm0f GXJRelKruGBX1AUSmQGzH3QWVTZByEXg03CYyuW1JpS9dua1JQwXYDp8GPfjPH34fphrEM PqPSLfYVtA37s44YgNhOZTvaBku3gJS02TfBGwufc8t7d4appweoFtg51tReCPf8j4V8he Z+mD371U4EkW+co3gqwDK2Fdq5YKCwjbDlz6E/fe3AKAN2NdHCRiZ1Nr6gYdaGFHckcfQG e2o98iMkPAD9m50o4urXH/X/QFKloWE6acK9RQB+nRhjsDTA48xmhbt8O5cBAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671584298; a=rsa-sha256; cv=none; b=u85Qv/NxlXQgO+65U/9WGGzGahdirJkQeZEvEzYOJfT3pHYGkAEMUdls9hHiINTyzLImij mWxIGZ1Gp1fXWANOLyxV7RJKm8TbUp9+kkiT0tyWj/RmbiLOQFpIAHog7ylraGeZ4IPNhK kboguphxFi4b3IYIXrNzIg6b2jp7CTMASbyhlVXnK7k/PPw4fvf5sGx09noCZLNvi9qL17 olLu55LtdLM9QAnU+68Ud7sMX+gfU83idUFHQzotB6mXVhkrnsdzr9+DJ4xRx2w398uwkM 6s5yO4ZoHtufEh6YjFH0/63cC+uq49MwitJXRt7GYw6EF6jQwTAV+E3Fvkjpag== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NcFRt333rzw0T; Wed, 21 Dec 2022 00:58:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BL0wIeO051051; Wed, 21 Dec 2022 00:58:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BL0wImL051050; Wed, 21 Dec 2022 00:58:18 GMT (envelope-from git) Date: Wed, 21 Dec 2022 00:58:18 GMT Message-Id: <202212210058.2BL0wImL051050@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Piotr Kubaj Subject: git: 7519190dadba - main - www/firefox: fix webrtc on powerpc64 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7519190dadba480c8839e41a27036d1421506903 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by pkubaj: URL: https://cgit.FreeBSD.org/ports/commit/?id=7519190dadba480c8839e41a27036d1421506903 commit 7519190dadba480c8839e41a27036d1421506903 Author: Piotr Kubaj AuthorDate: 2022-12-21 00:58:02 +0000 Commit: Piotr Kubaj CommitDate: 2022-12-21 00:58:02 +0000 www/firefox: fix webrtc on powerpc64 Patch taken from https://github.com/zeldin/chromium_be/blob/master/chromium-89.0.4389.114/webrtc.patch (with paths corrected). --- www/firefox/Makefile | 4 +- www/firefox/files/patch-libwebrtc-powerpc64 | 264 ++++++++++++++++++++++++++++ 2 files changed, 266 insertions(+), 2 deletions(-) diff --git a/www/firefox/Makefile b/www/firefox/Makefile index 40bab8a35051..93c1af353ca7 100644 --- a/www/firefox/Makefile +++ b/www/firefox/Makefile @@ -1,6 +1,6 @@ PORTNAME= firefox DISTVERSION= 108.0.1 -PORTREVISION= 1 +PORTREVISION= 2 # DISTVERSIONSUFFIX= b9 PORTEPOCH= 2 CATEGORIES= www wayland @@ -52,7 +52,7 @@ MOZ_OPTIONS= --enable-application=browser \ .include .if ${ARCH} == powerpc64 -MOZ_OPTIONS+= --disable-webrtc --without-wasm-sandboxed-libraries +MOZ_OPTIONS+= --without-wasm-sandboxed-libraries .else BUILD_DEPENDS+= ${LOCALBASE}/share/wasi-sysroot/lib/wasm32-wasi/libc++abi.a:devel/wasi-libcxx \ ${LOCALBASE}/share/wasi-sysroot/lib/wasm32-wasi/libc.a:devel/wasi-libc \ diff --git a/www/firefox/files/patch-libwebrtc-powerpc64 b/www/firefox/files/patch-libwebrtc-powerpc64 new file mode 100644 index 000000000000..0dee667b1021 --- /dev/null +++ b/www/firefox/files/patch-libwebrtc-powerpc64 @@ -0,0 +1,264 @@ +From ebc07ec32002c53702eb6e53ee1532ad2e0dc2bd Mon Sep 17 00:00:00 2001 +From: Marcus Comstedt +Date: Fri, 12 Mar 2021 23:27:16 +0100 +Subject: [PATCH 1/2] wav: Swap header fields as needed + +--- + third_party/webrtc/common_audio/wav_header.cc | 48 +++++++++++++++++-- + 1 file changed, 44 insertions(+), 4 deletions(-) + +--- third_party/libwebrtc/common_audio/wav_header.cc ++++ third_party/libwebrtc/common_audio/wav_header.cc +@@ -26,10 +26,6 @@ + namespace webrtc { + namespace { + +-#ifndef WEBRTC_ARCH_LITTLE_ENDIAN +-#error "Code not working properly for big endian platforms." +-#endif +- + #pragma pack(2) + struct ChunkHeader { + uint32_t ID; +@@ -111,9 +107,15 @@ static_assert(sizeof(WavHeaderIeeeFloat) == kIeeeFloatWavHeaderSize, + "no padding in header"); + + uint32_t PackFourCC(char a, char b, char c, char d) { ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ uint32_t packed_value = ++ static_cast(a) << 24 | static_cast(b) << 16 | ++ static_cast(c) << 8 | static_cast(d); ++#else + uint32_t packed_value = + static_cast(a) | static_cast(b) << 8 | + static_cast(c) << 16 | static_cast(d) << 24; ++#endif + return packed_value; + } + +@@ -172,6 +174,9 @@ bool FindWaveChunk(ChunkHeader* chunk_header, + if (readable->Read(chunk_header, sizeof(*chunk_header)) != + sizeof(*chunk_header)) + return false; // EOF. ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ chunk_header->Size = __builtin_bswap32(chunk_header->Size); ++#endif + if (ReadFourCC(chunk_header->ID) == sought_chunk_id) + return true; // Sought chunk found. + // Ignore current chunk by skipping its payload. +@@ -185,6 +190,14 @@ bool ReadFmtChunkData(FmtPcmSubchunk* fmt_subchunk, WavHeaderReader* readable) { + if (readable->Read(&(fmt_subchunk->AudioFormat), kFmtPcmSubchunkSize) != + kFmtPcmSubchunkSize) + return false; ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ fmt_subchunk->AudioFormat = __builtin_bswap16(fmt_subchunk->AudioFormat); ++ fmt_subchunk->NumChannels = __builtin_bswap16(fmt_subchunk->NumChannels); ++ fmt_subchunk->SampleRate = __builtin_bswap32(fmt_subchunk->SampleRate); ++ fmt_subchunk->ByteRate = __builtin_bswap32(fmt_subchunk->ByteRate); ++ fmt_subchunk->BlockAlign = __builtin_bswap16(fmt_subchunk->BlockAlign); ++ fmt_subchunk->BitsPerSample = __builtin_bswap16(fmt_subchunk->BitsPerSample); ++#endif + const uint32_t fmt_size = fmt_subchunk->header.Size; + if (fmt_size != kFmtPcmSubchunkSize) { + // There is an optional two-byte extension field permitted to be present +@@ -225,6 +238,17 @@ void WritePcmWavHeader(size_t num_channels, + header.fmt.BitsPerSample = static_cast(8 * bytes_per_sample); + header.data.header.ID = PackFourCC('d', 'a', 't', 'a'); + header.data.header.Size = static_cast(bytes_in_payload); ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ header.riff.header.Size = __builtin_bswap32(header.riff.header.Size); ++ header.fmt.header.Size = __builtin_bswap32(header.fmt.header.Size); ++ header.fmt.AudioFormat = __builtin_bswap16(header.fmt.AudioFormat); ++ header.fmt.NumChannels = __builtin_bswap16(header.fmt.NumChannels); ++ header.fmt.SampleRate = __builtin_bswap32(header.fmt.SampleRate); ++ header.fmt.ByteRate = __builtin_bswap32(header.fmt.ByteRate); ++ header.fmt.BlockAlign = __builtin_bswap16(header.fmt.BlockAlign); ++ header.fmt.BitsPerSample = __builtin_bswap16(header.fmt.BitsPerSample); ++ header.data.header.Size = __builtin_bswap32(header.data.header.Size); ++#endif + + // Do an extra copy rather than writing everything to buf directly, since buf + // might not be correctly aligned. +@@ -261,6 +285,19 @@ void WriteIeeeFloatWavHeader(size_t num_channels, + header.fact.SampleLength = static_cast(num_channels * num_samples); + header.data.header.ID = PackFourCC('d', 'a', 't', 'a'); + header.data.header.Size = static_cast(bytes_in_payload); ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ header.riff.header.Size = __builtin_bswap32(header.riff.header.Size); ++ header.fmt.header.Size = __builtin_bswap32(header.fmt.header.Size); ++ header.fmt.AudioFormat = __builtin_bswap16(header.fmt.AudioFormat); ++ header.fmt.NumChannels = __builtin_bswap16(header.fmt.NumChannels); ++ header.fmt.SampleRate = __builtin_bswap32(header.fmt.SampleRate); ++ header.fmt.ByteRate = __builtin_bswap32(header.fmt.ByteRate); ++ header.fmt.BlockAlign = __builtin_bswap16(header.fmt.BlockAlign); ++ header.fmt.BitsPerSample = __builtin_bswap16(header.fmt.BitsPerSample); ++ header.fact.header.Size = __builtin_bswap32(header.fact.header.Size); ++ header.fact.SampleLength = __builtin_bswap32(header.fact.SampleLength); ++ header.data.header.Size = __builtin_bswap32(header.data.header.Size); ++#endif + + // Do an extra copy rather than writing everything to buf directly, since buf + // might not be correctly aligned. +@@ -387,6 +424,9 @@ bool ReadWavHeader(WavHeaderReader* readable, + return false; + if (ReadFourCC(header.riff.Format) != "WAVE") + return false; ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ header.riff.header.Size = __builtin_bswap32(header.riff.header.Size); ++#endif + + // Find "fmt " and "data" chunks. While the official Wave file specification + // does not put requirements on the chunks order, it is uncommon to find the +-- +2.26.3 + + +From 28adaefe12a045a4adf7fdf56eb4e57db46dbe5e Mon Sep 17 00:00:00 2001 +From: Marcus Comstedt +Date: Fri, 12 Mar 2021 23:28:25 +0100 +Subject: [PATCH 2/2] wav: Implement sample swapping + +--- + third_party/webrtc/common_audio/wav_file.cc | 50 ++++++++++++++------- + 1 file changed, 34 insertions(+), 16 deletions(-) + +--- third_party/libwebrtc/common_audio/wav_file.cc ++++ third_party/libwebrtc/common_audio/wav_file.cc +@@ -89,10 +89,6 @@ void WavReader::Reset() { + + size_t WavReader::ReadSamples(const size_t num_samples, + int16_t* const samples) { +-#ifndef WEBRTC_ARCH_LITTLE_ENDIAN +-#error "Need to convert samples to big-endian when reading from WAV file" +-#endif +- + size_t num_samples_left_to_read = num_samples; + size_t next_chunk_start = 0; + while (num_samples_left_to_read > 0 && num_unread_samples_ > 0) { +@@ -107,6 +103,9 @@ size_t WavReader::ReadSamples(const size_t num_samples, + num_samples_read = num_bytes_read / sizeof(samples_to_convert[0]); + + for (size_t j = 0; j < num_samples_read; ++j) { ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ *(uint32_t*)&samples_to_convert[j] = __builtin_bswap32(*(uint32_t*)&samples_to_convert[j]); ++#endif + samples[next_chunk_start + j] = FloatToS16(samples_to_convert[j]); + } + } else { +@@ -114,6 +113,11 @@ size_t WavReader::ReadSamples(const size_t num_samples, + num_bytes_read = file_.Read(&samples[next_chunk_start], + chunk_size * sizeof(samples[0])); + num_samples_read = num_bytes_read / sizeof(samples[0]); ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ for (size_t j = 0; j < num_samples_read; ++j) { ++ samples[next_chunk_start + j] = __builtin_bswap16(samples[next_chunk_start + j]); ++ } ++#endif + } + RTC_CHECK(num_samples_read == 0 || (num_bytes_read % num_samples_read) == 0) + << "Corrupt file: file ended in the middle of a sample."; +@@ -129,10 +133,6 @@ size_t WavReader::ReadSamples(const size_t num_samples, + } + + size_t WavReader::ReadSamples(const size_t num_samples, float* const samples) { +-#ifndef WEBRTC_ARCH_LITTLE_ENDIAN +-#error "Need to convert samples to big-endian when reading from WAV file" +-#endif +- + size_t num_samples_left_to_read = num_samples; + size_t next_chunk_start = 0; + while (num_samples_left_to_read > 0 && num_unread_samples_ > 0) { +@@ -147,8 +147,13 @@ size_t WavReader::ReadSamples(const size_t num_samples, float* const samples) { + num_samples_read = num_bytes_read / sizeof(samples_to_convert[0]); + + for (size_t j = 0; j < num_samples_read; ++j) { ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ samples[next_chunk_start + j] = ++ static_cast(static_cast(__builtin_bswap16(samples_to_convert[j]))); ++#else + samples[next_chunk_start + j] = + static_cast(samples_to_convert[j]); ++#endif + } + } else { + RTC_CHECK_EQ(format_, WavFormat::kWavFormatIeeeFloat); +@@ -157,6 +162,9 @@ size_t WavReader::ReadSamples(const size_t num_samples, float* const samples) { + num_samples_read = num_bytes_read / sizeof(samples[0]); + + for (size_t j = 0; j < num_samples_read; ++j) { ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ *(uint32_t*)&samples[next_chunk_start + j] = __builtin_bswap32(*(uint32_t*)&samples[next_chunk_start + j]); ++#endif + samples[next_chunk_start + j] = + FloatToFloatS16(samples[next_chunk_start + j]); + } +@@ -213,23 +221,31 @@ WavWriter::WavWriter(FileWrapper file, + } + + void WavWriter::WriteSamples(const int16_t* samples, size_t num_samples) { +-#ifndef WEBRTC_ARCH_LITTLE_ENDIAN +-#error "Need to convert samples to little-endian when writing to WAV file" +-#endif +- + for (size_t i = 0; i < num_samples; i += kMaxChunksize) { + const size_t num_remaining_samples = num_samples - i; + const size_t num_samples_to_write = + std::min(kMaxChunksize, num_remaining_samples); + + if (format_ == WavFormat::kWavFormatPcm) { ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ std::array converted_samples; ++ for (size_t j = 0; j < num_samples_to_write; ++j) { ++ converted_samples[j] = __builtin_bswap16(samples[i + j]); ++ } ++ RTC_CHECK( ++ file_.Write(converted_samples.data(), num_samples_to_write * sizeof(samples[0]))); ++#else + RTC_CHECK( + file_.Write(&samples[i], num_samples_to_write * sizeof(samples[0]))); ++#endif + } else { + RTC_CHECK_EQ(format_, WavFormat::kWavFormatIeeeFloat); + std::array converted_samples; + for (size_t j = 0; j < num_samples_to_write; ++j) { + converted_samples[j] = S16ToFloat(samples[i + j]); ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ *(uint32_t*)&converted_samples[j] = __builtin_bswap32(*(uint32_t*)&converted_samples[j]); ++#endif + } + RTC_CHECK( + file_.Write(converted_samples.data(), +@@ -243,10 +259,6 @@ void WavWriter::WriteSamples(const int16_t* samples, size_t num_samples) { + } + + void WavWriter::WriteSamples(const float* samples, size_t num_samples) { +-#ifndef WEBRTC_ARCH_LITTLE_ENDIAN +-#error "Need to convert samples to little-endian when writing to WAV file" +-#endif +- + for (size_t i = 0; i < num_samples; i += kMaxChunksize) { + const size_t num_remaining_samples = num_samples - i; + const size_t num_samples_to_write = +@@ -256,6 +268,9 @@ void WavWriter::WriteSamples(const float* samples, size_t num_samples) { + std::array converted_samples; + for (size_t j = 0; j < num_samples_to_write; ++j) { + converted_samples[j] = FloatS16ToS16(samples[i + j]); ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ converted_samples[j] = __builtin_bswap16(converted_samples[j]); ++#endif + } + RTC_CHECK( + file_.Write(converted_samples.data(), +@@ -265,6 +280,9 @@ void WavWriter::WriteSamples(const float* samples, size_t num_samples) { + std::array converted_samples; + for (size_t j = 0; j < num_samples_to_write; ++j) { + converted_samples[j] = FloatS16ToFloat(samples[i + j]); ++#ifndef WEBRTC_ARCH_LITTLE_ENDIAN ++ *(uint32_t*)&converted_samples[j] = __builtin_bswap32(*(uint32_t*)&converted_samples[j]); ++#endif + } + RTC_CHECK( + file_.Write(converted_samples.data(), +-- +2.26.3 +