From owner-cvs-sys Mon Aug 4 00:53:53 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
by hub.freebsd.org (8.8.5/8.8.5) id AAA20624
for cvs-sys-outgoing; Mon, 4 Aug 1997 00:53:53 -0700 (PDT)
Received: from critter.dk.tfs.com ([140.145.230.252])
by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA20618;
Mon, 4 Aug 1997 00:53:44 -0700 (PDT)
Received: from critter.dk.tfs.com (localhost [127.0.0.1])
by critter.dk.tfs.com (8.8.6/8.8.5) with ESMTP id JAA14328;
Mon, 4 Aug 1997 09:51:52 +0200 (CEST)
To: dg@root.com
cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
From: Poul-Henning Kamp <phk@dk.tfs.com>
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c
In-reply-to: Your message of "Mon, 04 Aug 1997 00:41:38 PDT."
<199708040741.AAA08057@implode.root.com>
Date: Mon, 04 Aug 1997 09:51:51 +0200
Message-ID: <14326.870681111@critter.dk.tfs.com>
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk
In message <199708040741.AAA08057@implode.root.com>, David Greenman writes:
>>phk 1997/08/04 00:30:45 PDT
>>
>> Modified files:
>> sys/ufs/ffs ffs_alloc.c
>> Log:
>> We got a couple of "map mismatch" panics from the following
>> code. According to the crash dump, bpref is set to 445
>> and cgp->cg_nclusterblks is 444. Hence in the for loop,
>> the test fails immediately but the following failure check
>> (got == cgp->cg_nclusterblks) doesn't trigger because got >
>> cgp->cg_nclusterblks. This wreaks havoc in the code after that.
>>
>> Fix: Move one source bit to the left :-)
>>
>> Noticed by: Mike Hibler <mike@fast.cs.utah.edu>
>> Submitted by: Kirk McKusick <mckusick@McKusick.COM>
>
> Just so people aren't confused: the above patch has no affect on FreeBSD;
>it's in an area of code that isn't even compiled.
>
>-DG
>
>David Greenman
>Core-team/Principal Architect, The FreeBSD Project
True, should have said that. This commit is just to keep us in sync
with Kirk.
--
Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team.
http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox.
whois: [PHK] | phk@tfs.com TRW Financial Systems, Inc.
Power and ignorance is a disgusting cocktail.