From owner-dev-commits-src-all@freebsd.org Fri Feb 19 16:14:18 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B9EA1531CF9 for ; Fri, 19 Feb 2021 16:14:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhxV24dNrz4gW9 for ; Fri, 19 Feb 2021 16:14:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id z128so1466301qkc.12 for ; Fri, 19 Feb 2021 08:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QGQR11q7noqIrb7K1UZSj/pZQ32BnK6Eqtp/Z078WMU=; b=CcKZT14T3AbCJLEsvHeUJp3eD7xvJBGQKbwfpa8o1vOg4DVdG9BxykMHXHJKJIAplA avpCUIkALEKIfx1e5dYTLmdRYvOAHKiRJu7LfN0gec3v7Uv5d4HHBO1AwQeBRO65uErO mS+avUaTqSQlq5YnkoHvpzJAOA/pBtb6lHTIW/X4aTL45XeHyoXwXxYsnroF14ajMXxQ IXwUXa+2mWFIDV1TWA8Lj4ETADTV5l8SiPc7uUZtRTafjOq8xBktgUZmRywi1oHnTRL6 iXNOvurQy3H/skpVg80HrRfoZDKosxzTFummllrBLYenQNOu6l3QFDRLrwpDyDGJ2W9F Lftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QGQR11q7noqIrb7K1UZSj/pZQ32BnK6Eqtp/Z078WMU=; b=t1Qu3NALzoB7tTHm/wH69WOZgcnLp2Dly7/M0F5EkaM+RML/ES3ZRauOOA4dQfoUWn PInj34mwSsf+TU5DS4drjqrPqTNLcuCbt5pZsIqcz7RDv/RNLUk8+BCkBCnmRFqCupXb ephuvsAujN8Z5LlRU7LZY4JQ+HWAqitHK7i+gNyXm/Ko4No7gtT+8Bh3/LLgZcQA5+hr xKhF5LjsdANZnI4diwIKy4bJ77HTJxXa7vZTGEVBgCE97RZvfpxPCEL96Lm61T3NcZ1x Io3mt8jkQJEPur3h0n9SQww+zhl5O7cKuQohVnffvrHQ6tMMux/qR0ZkumC1dDSd3nVG aMIw== X-Gm-Message-State: AOAM532UKFjtWp4mU/b0GEEBUm9bq2MdIAZ4L74apsmK2npFLu3h+uV0 ZLGBPXFx+G0JCt5YNbnXpiPUgDPHqkHt2fY2UVe4Sw== X-Google-Smtp-Source: ABdhPJyA1VzAOzFghnbK3gdXfc3AgpRhvAdQuXrpfLJzAj0acidm3YprJxlMElLZV+OlBbEzIRMiuFZ+DxqFKxEP3oM= X-Received: by 2002:a05:620a:1d:: with SMTP id j29mr9838219qki.44.1613751257769; Fri, 19 Feb 2021 08:14:17 -0800 (PST) MIME-Version: 1.0 References: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> <9687575c-dd7c-1496-850b-2018f4bca3da@FreeBSD.org> <3045F222-DBAC-463C-B429-075B2CFB115A@freebsd.org> <012169A0-67EC-48B7-A1CB-2A9921EF63FA@freebsd.org> In-Reply-To: From: Warner Losh Date: Fri, 19 Feb 2021 09:14:07 -0700 Message-ID: Subject: Re: git: 24fd63e0970f - main - mips: Don't set __NO_TLS to disable some uses of TLS. To: Konstantin Belousov Cc: Brandon Bergren , Jessica Clarke , John Baldwin , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DhxV24dNrz4gW9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 16:14:18 -0000 On Fri, Feb 19, 2021 at 2:43 AM Konstantin Belousov wrote: > On Thu, Feb 18, 2021 at 07:54:22PM -0600, Brandon Bergren wrote: > > > > > > On Thu, Feb 18, 2021, at 7:07 PM, Jessica Clarke wrote: > > > On 19 Feb 2021, at 00:03, Brandon Bergren wrote: > > > > > > Ok, so the mistake was not deleting it 8 years ago and instead leaving > > > it around to become part of the ABI. The issue you're referring to > > > specifically is __getCurrentRuneLocale and _ThreadRuneLocale (the > > > latter doesn't exist for __NO_TLS, and the former changes between > > > static inline and extern)? __NO_TLS should have blocked powerpc64 (and > > > mips) from becoming tier 2 IMO, but we're stuck with it, so yeah, it's > > > a major ABI break (frustratingly tiny but breaks the core system > > > libraries) and thus can't be MFC'ed. > > > > > > Jess > > > > Right. > > > > And I fixed it for powerpc64 for 13 finally becuase I had the excuse of > "Well, we're switching to an entirely incompatible ABI due to lld not > supporting ELFv1, so I might as well fix this one at the same time since > we're forcing people to reinstall from scratch anyway." > > > > So yeah, in HEAD, all references to __NO_TLS can go away fully, in > stable/13 the mips part probably has to stay (riscv can play the tier 3 > card though), and in 12 it's baked in for life. > > > > The "(defined(__powerpc64__) && (!defined(_CALL_ELF) || _CALL_ELF == > 1))" part is no longer relevant for 13 or HEAD, since the ELFv2 transition > is over and done with as of the end of 2019. I probably should have taken > that part out last year, since it was meant to just be a temporary > compatibility shim so that people could compile both the gcc4.2 ELFv1 and > llvm ELFv2 versions of 13-CURRENT out of the same tree back when we were in > the middle of switching over. > > So why didn't you go ahead and removed at least the remaining block that > defines __NO_TLS for PowerPC? I promise to clean the tree out of its > uses after that. > FWIW: Mips likely can play the 'not very popular tier 2 card trending towards tier 3' card, at least for 13 since (a) 13.0 isn't out yet and (b) the project doesn't produce mips binaries. It could likely even play it for 12, but that might be a wee bit disruptive to the few users of it we have. Warner