Date: Wed, 20 Apr 2005 14:51:44 -0500 From: "Jeremy Messenger" <mezz7@cox.net> To: "Miguel Mendez" <flynn@energyhq.es.eu.org> Cc: gnome@freebsd.org Subject: Re: Can somebody please have a look at ports/78931? Message-ID: <op.spjqsimr9aq2h7@mezz.mezzweb.com> In-Reply-To: <20050420203250.597f6ae8.flynn@energyhq.es.eu.org> References: <20050420194825.76ebf3c0.flynn@energyhq.es.eu.org> <op.spjl56u59aq2h7@mezz.mezzweb.com> <20050420203250.597f6ae8.flynn@energyhq.es.eu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Apr 2005 13:32:50 -0500, Miguel Mendez
<flynn@energyhq.es.eu.org> wrote:
> On Wed, 20 Apr 2005 13:11:56 -0500
> "Jeremy Messenger" <mezz7@cox.net> wrote:
>
>> Not useful to me, but it's up to someone in my team if he likes OPTIONS
>> stuff. Anyway, I took a bit look at it and I don't think few knobs will
>
> Could you elaborate on why you don't think OPTIONS are useful? I'm
> honestly interested.
>
>> work because of the OPTIONS don't work with the autocheck very well. I
>> only see useful in your PR is that two knobs that have exist() should be
>> move under .include <bsd.port.pre.mk> and change DATADIR in plist.
>
> I did test builds with BATCH=yes and it worked fine. If there's
> anything wrong I'd love to know about it.
Nevermind, I thought the RSVG2 has '.if ${HAVE_GNOME:Mlibrsvg2}!=""'.. The
bsd.gnome.mk doesn't work with OPTIONS yet.
> To make it clear: Whether the
> consensus is to get it in the tree or drop it, it's fine. What I'd like
> to avoid is to have the PR sitting in limbo for months.
If nobody touch this PR for two more weeks or more maybe in May, then I
will taking and commit it w/out add OPTIONS stuff then close it. That
should give my team plenty of time if they want to add OPTIONS or make any
comment on it.
Cheers,
Mezz
> Cheers,
--
mezz7@cox.net - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.spjqsimr9aq2h7>