From owner-p4-projects@FreeBSD.ORG  Fri Oct 11 18:41:58 2013
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
 id 25418241; Fri, 11 Oct 2013 18:41:58 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id DB39923F
 for <perforce@freebsd.org>; Fri, 11 Oct 2013 18:41:57 +0000 (UTC)
 (envelope-from jonathan@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [8.8.178.74])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C7CC82A90
 for <perforce@freebsd.org>; Fri, 11 Oct 2013 18:41:57 +0000 (UTC)
Received: from skunkworks.freebsd.org ([127.0.1.74])
 by skunkworks.freebsd.org (8.14.7/8.14.7) with ESMTP id r9BIfvh5043120
 for <perforce@freebsd.org>; Fri, 11 Oct 2013 18:41:57 GMT
 (envelope-from jonathan@freebsd.org)
Received: (from perforce@localhost)
 by skunkworks.freebsd.org (8.14.7/8.14.6/Submit) id r9BIfvrY043117
 for perforce@freebsd.org; Fri, 11 Oct 2013 18:41:57 GMT
 (envelope-from jonathan@freebsd.org)
Date: Fri, 11 Oct 2013 18:41:57 GMT
Message-Id: <201310111841.r9BIfvrY043117@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
 jonathan@freebsd.org using -f
From: Jonathan Anderson <jonathan@FreeBSD.org>
Subject: PERFORCE change 1047924 for review
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.14
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2013 18:41:58 -0000

http://p4web.freebsd.org/@@1047924?ac=10

Change 1047924 by jonathan@jonathan-on-zenith on 2013/10/11 18:41:21

	The fix is in?

Affected files ...

.. //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/libtesla/tesla_internal.h#16 edit
.. //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/libtesla/tesla_update.c#15 edit

Differences ...

==== //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/libtesla/tesla_internal.h#16 (text+ko) ====

@@ -89,7 +89,7 @@
 	struct tesla_lifetime_event	 tls_end;
 
 	/** A place to register a few classes that share this lifetime. */
-	struct tesla_class*		 tls_classes[4];
+	struct tesla_class*		 tls_classes[32];
 
 	/** A place to register more classes that share this lifetime. */
 	struct tesla_class*		*tls_dyn_classes;

==== //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/libtesla/tesla_update.c#15 (text+ko) ====

@@ -120,6 +120,8 @@
 			class->tc_automaton->ta_cleanup_symbol, &empty_key);
 	}
 
+	bzero(ls->tls_classes, sizeof(ls->tls_classes));
+
 	const size_t dynamic_classes = ls->tls_dyn_count;
 	for (size_t i = 0; i < dynamic_classes; i++) {
 		tesla_class *class = ls->tls_dyn_classes[i];
@@ -129,6 +131,8 @@
 		tesla_update_class_state(class, store,
 			class->tc_automaton->ta_cleanup_symbol, &empty_key);
 	}
+
+	//bzero(ls->tls_dyn_classes, ls->tls_dyn_count * sizeof(ls->tls_classes[0]));
 }
 
 
@@ -252,7 +256,7 @@
 			 *           when we know it's safe.
 			 */
 			ev_err(autom, symbol, TESLA_ERROR_ENOMEM,
-			       "out of dynamic registration space in lifetime");
+			       "out of static registration space in lifetime");
 #else
 			static size_t unit_size =
 				sizeof(ls->tls_dyn_classes[0]);