From owner-cvs-all@FreeBSD.ORG  Mon Feb 18 15:38:05 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7BFAD16A418;
	Mon, 18 Feb 2008 15:38:05 +0000 (UTC) (envelope-from bra@fsn.hu)
Received: from people.fsn.hu (people.fsn.hu [195.228.252.137])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D10413C4EB;
	Mon, 18 Feb 2008 15:38:04 +0000 (UTC) (envelope-from bra@fsn.hu)
Received: from [172.16.129.173] (fw.axelero.hu [195.228.243.120])
	by people.fsn.hu (Postfix) with ESMTP id 28F297CA24;
	Mon, 18 Feb 2008 16:18:55 +0100 (CET)
Message-ID: <47B9A1D9.7020209@fsn.hu>
Date: Mon, 18 Feb 2008 16:18:49 +0100
From: Attila Nagy <bra@fsn.hu>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Yar Tikhiy <yar@comp.chem.msu.su>
References: <200802141704.m1EH4VL4099009@repoman.freebsd.org>	<86y79i5syt.fsf@ds4.des.no>
	<20080218142626.GI30694@comp.chem.msu.su>
In-Reply-To: <20080218142626.GI30694@comp.chem.msu.su>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Dag-Erling Sm??rgrav <des@des.no>, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_mount.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Feb 2008 15:38:05 -0000

On 2008.02.18. 15:26, Yar Tikhiy wrote:
> On Mon, Feb 18, 2008 at 01:50:34PM +0100, Dag-Erling Sm??rgrav wrote:
>   
>> Yar Tikhiy <yar@FreeBSD.org> writes:
>>     
>>>   Log:
>>>   In the new order of things dictated by nmount(2), a read-only mount
>>>   is to be requested via a "ro" option.  At the same time, MNT_RDONLY
>>>   is gradually becoming an indicator of the current state of the FS
>>>   instead of a command flag.  Today passing MNT_RDONLY alone to the
>>>   kernel's mount machinery will lead to various glitches.  (See the
>>>   PRs for examples.)
>>>   
>>>   Therefore mount the root FS with a "ro" option instead of the
>>>   MNT_RDONLY flag.  (Note that MNT_RDONLY still is added to the mount
>>>   flags internally, by vfs_donmount(), if "ro" was specified.)
>>>       
>> Can you guarantee that this will not f*** up the bootp / dhcp + nfsroot
>> case?  There are dragons in that code which were decidedly not funny to
>> track down and fix.
>>     
>
> Indeed; or, as a Russian proverb has it, "Just don't touch the sh*t,
> and it won't stink". :-) But, fortunately, I've just had a chance
> to test this WRT the NFS_ROOT case.  Thank Daemon, that code path
> is much clearer now than it used to be in the 4.4BSD days.
>   
What about the BOOTP_NFSROOT case? I've corresponded with Kris after his 
change to default TCP and NFSv3 (and I have some stuff to try for his 
request), could you also try that part too?