From owner-freebsd-bugs Sun Feb 6 23:29:30 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by builder.freebsd.org (Postfix) with ESMTP id F40DD3E1B for ; Sun, 6 Feb 2000 23:29:19 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id XAA04519; Sun, 6 Feb 2000 23:30:01 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from mail.iserlohn.netsurf.de (mail.iserlohn.netsurf.de [194.195.194.253]) by builder.freebsd.org (Postfix) with ESMTP id F21993E84 for ; Sun, 6 Feb 2000 23:20:23 -0800 (PST) Received: from schumann.cx (hennen32s.iserlohn.netsurf.de [194.195.194.226]) by mail.iserlohn.netsurf.de (8.9.1/8.9.1) with SMTP id IAA32573 for ; Mon, 7 Feb 2000 08:21:16 +0100 Received: (qmail 7355 invoked from network); 7 Feb 2000 07:21:03 -0000 Received: from unknown (HELO flaubert.foo.bar) (192.168.0.99) by guerilla.foo.bar with SMTP; 7 Feb 2000 07:21:03 -0000 Received: (qmail 6910 invoked by uid 500); 7 Feb 2000 07:21:25 -0000 Received: (qmail 6854 invoked from network); 7 Feb 2000 07:19:31 -0000 Received: from guerilla.foo.bar (HELO schumann.cx) (192.168.0.1) by flaubert.foo.bar with SMTP; 7 Feb 2000 07:19:31 -0000 Received: (qmail 7334 invoked by alias); 7 Feb 2000 07:19:09 -0000 Received: (qmail 7330 invoked by uid 500); 7 Feb 2000 07:19:09 -0000 Message-Id: <20000207071909.7329.qmail@schumann.cx> Date: 7 Feb 2000 07:19:09 -0000 From: sascha@schumann.cx To: FreeBSD-gnats-submit@freebsd.org Cc: sascha@schumann.cx X-Send-Pr-Version: 3.2 Subject: kern/16551: cosmetic cleanup in sys/dev/ppbus/pcfclock.c Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 16551 >Category: kern >Synopsis: cosmetic cleanup in sys/dev/ppbus/pcfclock.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Feb 6 23:30:01 PST 2000 >Closed-Date: >Last-Modified: >Originator: Sascha Schumann >Release: FreeBSD 4.0-CURRENT i386 >Organization: >Environment: NA >Description: Some minor cleanup >How-To-Repeat: NA >Fix: --- /usr/src/sys/dev/ppbus/pcfclock.c Sun Jan 23 15:41:04 2000 +++ pcfclock.c Sat Jan 29 12:13:38 2000 @@ -13,7 +13,7 @@ * THIS SOFTWARE IS PROVIDED BY SASCHA SCHUMANN ``AS IS'' AND ANY EXPRESS OR * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO - * EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, * OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF @@ -52,7 +52,6 @@ struct pcfclock_data { int count; - struct ppb_device pcfclock_dev; }; #define DEVTOSOFTC(dev) \ @@ -126,7 +125,6 @@ static void pcfclock_identify(driver_t *driver, device_t parent) { - BUS_ADD_CHILD(parent, 0, PCFCLOCK_NAME, 0); } @@ -186,9 +184,8 @@ device_t ppbus = device_get_parent(pcfclockdev); sc->count--; - if (sc->count == 0) { + if (sc->count == 0) ppb_release_bus(ppbus, pcfclockdev); - } return (0); } @@ -223,6 +220,7 @@ year = NR(buf, 14); if (year < 70) year += 100; + printf(PCFCLOCK_NAME "%d: %02d.%02d.%4d %02d:%02d:%02d, " "battery status: %s\n", unit, >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message