From owner-cvs-src@FreeBSD.ORG Thu Jan 25 10:29:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0362C16A402; Thu, 25 Jan 2007 10:29:24 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.freebsd.org (Postfix) with ESMTP id 76F4213C465; Thu, 25 Jan 2007 10:29:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id l0PATLWO006305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 Jan 2007 13:29:22 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id l0PATLdH006304; Thu, 25 Jan 2007 13:29:21 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 25 Jan 2007 13:29:21 +0300 From: Gleb Smirnoff To: Mohan Srinivasan Message-ID: <20070125102921.GK4485@FreeBSD.org> References: <200701250105.l0P15OUf053076@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200701250105.l0P15OUf053076@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_mbuf.c src/sys/sys mbuf.h src/sys/vm uma.h uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2007 10:29:24 -0000 Mohan, On Thu, Jan 25, 2007 at 01:05:23AM +0000, Mohan Srinivasan wrote: M> mohans 2007-01-25 01:05:23 UTC M> M> FreeBSD src repository M> M> Modified files: M> sys/kern kern_mbuf.c M> sys/sys mbuf.h M> sys/vm uma.h uma_core.c M> Log: M> Fix for problems that occur when all mbuf clusters migrate to the mbuf packet M> zone. Cluster allocations fail when this happens. Also processes that may have M> blocked on cluster allocations will never be woken up. Thanks to rwatson for M> an overview of the issue and pointers to the mbuma paper and his tool to dump M> out UMA zones. M> M> Reviewed by: andre@ Again, thanks for working on this! I've got a patch for some time, very similar to the one you've committed. However, it didn't help me entirely, because some processes could still be left sleeping. May be this is fixed by your wakeup_one() -> wakeup() change. I should test this ASAP. And please tell your opinion on the issue I've described in previous email. P.S. Let me do a small style nit-pick. :) All the UMA public functions are preceeded with "uma_", so it will be more nice to create a public uma_zone_drain(), that just calls internal zone_drain(). Like uma_print_stats() or uma_zdestroy() are. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE