From owner-freebsd-arm@FreeBSD.ORG Sun Dec 2 14:24:29 2007 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDCE616A419 for ; Sun, 2 Dec 2007 14:24:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 7F04B13C447 for ; Sun, 2 Dec 2007 14:24:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lB2EIGkx069866; Sun, 2 Dec 2007 07:18:17 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 02 Dec 2007 07:21:38 -0700 (MST) Message-Id: <20071202.072138.1723236577.imp@bsdimp.com> To: mlfbsd@ci0.org From: "M. Warner Losh" In-Reply-To: <20071202140920.GA40640@ci0.org> References: <474FF9BF.8090707@semihalf.com> <20071202140920.GA40640@ci0.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org Subject: Re: ARM arch subdir cleanups X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2007 14:24:29 -0000 In message: <20071202140920.GA40640@ci0.org> Olivier Houchard writes: : On Fri, Nov 30, 2007 at 12:53:35PM +0100, Rafal Jaworowski wrote: : > Hi, : > Attached are two patches with the following cleanups: : > : > 1. Convert nexus to standard device since it's mandatory anyway, remove stale : > nexus_io_asm.S and nexus_io.c : > : > 2. Streamline sys/conf/files.arm (and hence the kernel image contents): move : > asm routines to appropriate sys/arm//files. : > : > : > It seems to me other items in the ARM arch subdirectory would benefit from : > optimization/cleanups too, for example: : > : > - Shared OBIO routines. At least these are nearly identical and could be : > compressed into one I guess: : > : > xscale/i80321/obio_space.c : > xscale/i8134x/obio_space.c : > xscale/pxa2x0/pxa2x0_space.c (in P4) : > : > - Shared bus space generic methods. A lot of BS methods like *_bs_map(), : > _bs_subregion() etc. are copied in separate files for different ARM platforms, : > but most of this could be placed in one file, just like we have a common : > assembly routines in the arm/arm/bus_space_asm_generic.S. : > : > - Others like arm/arm/machdep.c and arm/arm/sys_machdep.c seem akin, could : > they be merged into one file? : > : > I can work on cleaning those up, would such changes be welcome? : > : > Rafal : : : Hi Rafal, : : I just committed your patches. Yes, this kind of work is very welcome. Indeed. I've done some work trying to get obio abstracted out across all architectures. The other thing that I'd like to see is a better defined board/cpu initialization sequence. Or to make better use of the one that's defined now and document it better. I made some bad choices, in hindsight, for the at91rm9200 port that are only now becoming apparent. Warner