From owner-freebsd-commit  Fri Dec 15 09:55:50 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA06384
          for freebsd-commit-outgoing; Fri, 15 Dec 1995 09:55:50 -0800 (PST)
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA06375
          for cvs-all-outgoing; Fri, 15 Dec 1995 09:55:45 -0800 (PST)
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA06365
          for cvs-sys-outgoing; Fri, 15 Dec 1995 09:55:43 -0800 (PST)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id JAA06355
          Fri, 15 Dec 1995 09:55:37 -0800 (PST)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id EAA24327; Sat, 16 Dec 1995 04:54:01 +1100
Date: Sat, 16 Dec 1995 04:54:01 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199512151754.EAA24327@godzilla.zeta.org.au>
To: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org,
        davidg@freefall.freebsd.org
Subject: Re: cvs commit: src/sys/i386/isa if_ed.c
Sender: owner-commit@FreeBSD.ORG
Precedence: bulk

>  Modified:    sys/i386/isa  if_ed.c
>  Log:
>  Changed arg type for pio functions.
>  Cast a few things appropriately to shut up the compiler.

Please fix problems, not compiler warnings.

In this case, I think the casts only work because the hardware ignores
some bits in the address (bits 14-15 of 0-31 for 16K cards and bits
13-15 for 8K cards?).  Conversions of the form

	(int)(buf - base)
	((int)buf) & 0x3fff

would be more obviously correct, but might be slower.

Bruce