From owner-freebsd-current@freebsd.org Thu May 31 11:40:27 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECCB5F752DB for ; Thu, 31 May 2018 11:40:26 +0000 (UTC) (envelope-from johalun0@gmail.com) Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 68F2E7F627 for ; Thu, 31 May 2018 11:40:26 +0000 (UTC) (envelope-from johalun0@gmail.com) Received: by mail-wr0-x22e.google.com with SMTP id l41-v6so32726557wre.7 for ; Thu, 31 May 2018 04:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=i0q4geH2kZ14tiyEGV5t7/ruQRp26ANuYXgazhB3eGs=; b=haQpNudn2Mbt317xROvgqfOxZeinL2Mg5QX/j5WiuHv3vI0cF8ZJ06e/iueNDTA8NA gzKd+TigEsL/v9/gTK46RIHiJFauZdTDRMsVdJ+w2g+NK5L/yDmhaTXsveAmeWr8J/+E luuG6bBoSp3QLcMbsPY8ApAOPPPKvuA4Ube1TDidbBGdLB+1KwJIGDDAanitlQckXr7a oeMUMy4bTi5BRgqNe3EItugeAUQDcCFmthLTEsxzNPKvcF17vtmntcuB3ybQSVNO+XqJ 1uEVgrpdbdcInJasXgZkmlMjZ3CVvS0uSW3vYIfhXSJdC7FznQ8EopQfar57Ds1DccVK rHxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=i0q4geH2kZ14tiyEGV5t7/ruQRp26ANuYXgazhB3eGs=; b=PsZpmTn9PnMhJHbbzsL4n1EG9IgyrymlU8cjPn6CJoK6hPLgRi2Xt6jzsDXVWPLirr gz311uEceZCbBa9oc+nHCBxa6TMDyNmw/UsYYEYsXLWbMmVOUSzd0nAgm7HStc0XiR3j 7Mua0MW3vzh+F60UL2UG9cthP8UhUrFvxAqZM+TQn09lfYyBhgUddITeHmXlLXpSLdz2 H5ebzZitLlnKVQkI0jgHtEoDO6YGnuwvFH5k/wpP4TcdR3fgSzmJKiTGXy5kAAndHk0s n2KpeJUZxAs5b3J6GmdtczGLmOjJHLiHZiGiT2XLg6x2tb0mkYwCepadCqrqYbEUS1rB IY+Q== X-Gm-Message-State: ALKqPwcPp1FiVBB8uE2ILGfmH5hh/pFUuhPlNmG6/oVcrYQm+dS2ejL2 qF7ZSNrj7zZjBnYeI2dFScqKp+RQvgYM7LRms9t9pw== X-Google-Smtp-Source: ADUXVKKoi84N/VXl/JPHWuNL4wySOcrhjW82O4xgpwQtzO77KI88PwdpaCkfL6OPYwNLjOmuhBn372ZFfd61s4+jZ7w= X-Received: by 2002:adf:aa08:: with SMTP id p8-v6mr4938476wrd.140.1527766825150; Thu, 31 May 2018 04:40:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Johannes Lundberg Date: Thu, 31 May 2018 12:39:48 +0100 Message-ID: Subject: Re: evdev + ps/2 dell touchpad weirdness To: freebsd-current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2018 11:40:27 -0000 On Thu, May 31, 2018 at 9:32 AM Johannes Lundberg wrote: > > > On Thu, May 31, 2018 at 8:45 AM Johannes Lundberg > wrote: > >> Hi >> >> I could swear this was working a couple of months ago but since >> installing new kernel+world a couple of times and revisiting using Weston >> or X with udev+evdev+libinput I can't get all the events. >> >> Using libinput-debug-events on my dell laptop touchpad (psm driver with >> hw.psm.synaptics=1) I get events for two finger scroll Y (no horizontal >> scroll but that's another issue), single finger tap (left mouse), two >> finger tap (right mouse) but not single finger movements, that is I can't >> move the mouse cursor... >> >> Changing to trackpoint, elantech, etc makes no difference. >> >> All packages are from stock ports. >> > > To add more information. With PSM_DEBUG in kernel I can see that I'm > getting interrupts for single finger movement > > psmintr: 38 f4 fd 00 00 00 > psmintr: 38 f4 ff 00 00 00 > psmintr: 18 f5 00 00 00 00 > psmintr: 18 f5 00 00 00 00 > psmintr: 18 f5 03 00 00 00 > psmintr: 18 f7 04 00 00 00 > psmintr: 18 f9 05 00 00 00 > > > Ok got the fix. Can someone commit? EV_REL is for pushing events. For evdev_push_rel(), use REL_{axis}. diff --git a/sys/dev/atkbdc/psm.c b/sys/dev/atkbdc/psm.c index 0b6a061e15b..227b73e7088 100644 --- a/sys/dev/atkbdc/psm.c +++ b/sys/dev/atkbdc/psm.c @@ -4966,8 +4966,8 @@ psmsoftintr(void *arg) if (evdev_rcpt_mask & EVDEV_RCPT_HW_MOUSE && sc->hw.model != MOUSE_MODEL_ELANTECH && sc->hw.model != MOUSE_MODEL_SYNAPTICS) { - evdev_push_rel(sc->evdev_r, EV_REL, x); - evdev_push_rel(sc->evdev_r, EV_REL, -y); + evdev_push_rel(sc->evdev_r, REL_X, x); + evdev_push_rel(sc->evdev_r, REL_Y, -y); switch (sc->hw.model) { case MOUSE_MODEL_EXPLORER: