From owner-freebsd-hackers@freebsd.org  Sat Nov 21 07:36:13 2015
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8394AA2A54F
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Sat, 21 Nov 2015 07:36:13 +0000 (UTC)
 (envelope-from dan_partelly@rdsor.ro)
Received: from mail.rdsor.ro (mail.rdsor.ro [193.231.238.10])
 by mx1.freebsd.org (Postfix) with ESMTP id 41CFE1D26
 for <freebsd-hackers@freebsd.org>; Sat, 21 Nov 2015 07:36:12 +0000 (UTC)
 (envelope-from dan_partelly@rdsor.ro)
Received: from [192.168.1.100] (unknown [79.119.24.18])
 by mail.rdsor.ro (Postfix) with ESMTP id 3D67015B48;
 Sat, 21 Nov 2015 09:36:11 +0200 (EET)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
Subject: Re: libUCL / UCL as FreeBSD config question
From: Dan Partelly <dan_partelly@rdsor.ro>
In-Reply-To: <20151120125846.31d4f4cc@m>
Date: Sat, 21 Nov 2015 09:36:11 +0200
Cc: freebsd-hackers@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <BBE2B74D-104E-49A6-B780-C26635FFA23D@rdsor.ro>
References: <5B598F72-C5DD-48FD-866D-F90E117D646E@rdsor.ro>
 <564F6118.5030702@freebsd.org> <1448048197.2765.74.camel@michaeleichorn.com>
 <564F771F.4060408@freebsd.org> <20151120125846.31d4f4cc@m>
To: Conrad Meyer <cemeyer@uw.edu>
X-Mailer: Apple Mail (2.3096.5)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Nov 2015 07:36:13 -0000

I fully support this point of view. A short term fix is uncalled for. 


> On 20 Nov 2015, at 22:58, Conrad Meyer <cemeyer@uw.edu> wrote:
> 
> On Fri, 20 Nov 2015 14:40:15 -0500
> Allan Jude <allanjude@freebsd.org> wrote:
>> The issue is that UCL allows comments anywhere, for example:
>> 
>> #above
>> FreeBSD: {
>>   /* before */ url:
>> "pkg+http://pkg.FreeBSD.org/${ABI}/latest", mirror_type: /*
>> middle */ "srv", signature_type: "fingerprints", /* after */
>>   # under
>>   fingerprints: "/root/keys/pkg", # inline-after
>>   enabled: yes
>> }
>> 
>> Etc. So the solution that was discussed was changing libucl
>> to use an Abstract Syntax Tree, but that is a lot of work.
>> So for now, I am not sure what the best approach is.
> 
> I think an AST that keeps comments is a good approach going
> forwards.  We don't need a short-term fix that is anything
> less than that.
> 
> Best,
> Conrad
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"