From owner-freebsd-ports-bugs@freebsd.org Sun Dec 13 20:51:12 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3DEFC4C2D7C for ; Sun, 13 Dec 2020 20:51:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CvGrw13wNz4sHH for ; Sun, 13 Dec 2020 20:51:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 247F14C2FDB; Sun, 13 Dec 2020 20:51:12 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2449C4C3244 for ; Sun, 13 Dec 2020 20:51:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CvGrw0SMQz4sL2 for ; Sun, 13 Dec 2020 20:51:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EC90D16014 for ; Sun, 13 Dec 2020 20:51:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0BDKpBpv002457 for ; Sun, 13 Dec 2020 20:51:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0BDKpBm9002456 for ports-bugs@FreeBSD.org; Sun, 13 Dec 2020 20:51:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 251822] net/miniupnpd: firewall type detection broken; upstream pull needed Date: Sun, 13 Dec 2020 20:51:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jeremy.fbbg@baymoo.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Dec 2020 20:51:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251822 Bug ID: 251822 Summary: net/miniupnpd: firewall type detection broken; upstream pull needed Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: jeremy.fbbg@baymoo.org CC: squat@squat.no CC: squat@squat.no Flags: maintainer-feedback?(squat@squat.no) SUMMARY The current in-tree version of miniupnpd does not correctly detect the host firewall type and defaults to building a version which is only compatible w= ith pf no matter the actual host firewall type. DETAILS miniupnpd supposedly can be built to use any one of the three supported Fre= eBSD firewalls: pf, ipfilter and ipfw. The build process attempts to discern whi= ch firewall to use by consulting /etc/rc.conf, but it does a poor job of doing= so because of a series of precondition checks it performs before attempting to load /etc/rc.conf. These preconditions fail and /etc/rc.conf is never loade= d. The build process then falls back to building the pf version. FIX In March 2020 I notified the miniupnpd team about this issue, opening a pull request and proposing a fix. The minupnp team accepted the change and incorporated it into their master branch rather quickly and released with miniupnp 2.2.0. According to the the HEAD of ports SVN the port distinfo file is still pinn= ed at version 2.1.20190210. It was last edited as of ports r496821, which means that it doesn't have the fix for this detection issue. UPSTREAM ISSUE The upstream pull request which fixes the firewall detection problem can be found at https://github.com/miniupnp/miniupnp/issues/431 UPSTREAM VERSION CONTAINING DETECTION FIX The full fix for this issue was applied in https://github.com/miniupnp/miniupnp/commit/040fbc40f86a88c14dd4d3f8409e878= 994839e76 Which then appears to have been incorporated into miniupnp version 2.2.0. --=20 You are receiving this mail because: You are the assignee for the bug.=