Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Oct 2023 01:08:43 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: c9e203ba3fb6 - releng/14.0 - vfs cache: mark vfs.cache.param.size as read-only
Message-ID:  <202310140108.39E18hhW052003@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch releng/14.0 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=c9e203ba3fb61feed5e64a7047273b105c49eb50

commit c9e203ba3fb61feed5e64a7047273b105c49eb50
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2023-09-22 21:32:23 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2023-10-14 01:05:45 +0000

    vfs cache: mark vfs.cache.param.size as read-only
    
    It was not meant to be writable and writes don't work correctly as they
    fail to resize the hash.
    
    (cherry picked from commit 33fdf1afaea931eaa5dd14e6c097d7ffafe2fb1a)
    (cherry picked from commit 3f4e6aa2ae7c5d7b086f76e7ec445ec71a60a627)
    
    Approved by:    re (gjb)
---
 sys/kern/vfs_cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 0f4d7526ebb5..631ce856efdf 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -405,7 +405,7 @@ static SYSCTL_NODE(_vfs_cache, OID_AUTO, param, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
     "Name cache parameters");
 
 static u_int __read_mostly	ncsize; /* the size as computed on creation or resizing */
-SYSCTL_UINT(_vfs_cache_param, OID_AUTO, size, CTLFLAG_RW, &ncsize, 0,
+SYSCTL_UINT(_vfs_cache_param, OID_AUTO, size, CTLFLAG_RD, &ncsize, 0,
     "Total namecache capacity");
 
 u_int ncsizefactor = 2;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202310140108.39E18hhW052003>