From owner-cvs-src@FreeBSD.ORG Mon Jul 4 09:53:28 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0E0E16A41C; Mon, 4 Jul 2005 09:53:28 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id A312343D4C; Mon, 4 Jul 2005 09:53:28 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id CB03446B27; Mon, 4 Jul 2005 05:53:27 -0400 (EDT) Date: Mon, 4 Jul 2005 10:58:15 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Peter Grehan In-Reply-To: <42C90419.8070509@freebsd.org> Message-ID: <20050704105721.Y2768@fledge.watson.org> References: <200507022313.j62NDWYC028248@repoman.freebsd.org> <42C90419.8070509@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Andrew Thompson Subject: Re: cvs commit: src/sys/amd64/include _types.h src/sys/i386/include _types.h src/sys/net if_bridge.c src/sys/netinet ip_var.h src/sys/netinet6 ip6_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2005 09:53:29 -0000 On Mon, 4 Jul 2005, Peter Grehan wrote: >> Check the alignment of the IP header before passing the packet up to the >> packet filter. This would cause a panic on architectures that require >> strict >> alignment such as sparc64 (tier1) and ia64/ppc (tier2). > > FYI, any modern ppc implementation doesn't require strict alignment for > integer load/stores though there's a performance penalty for having to > split the access into smaller ones. While it's not immediately relevant to the IP code, generally speaking, is it the case that non-aligned integer reads can be non-atomic with respect to other CPUs due to the multiple access implementation? Robert N M Watson