From owner-cvs-src@FreeBSD.ORG Fri Sep 21 19:27:31 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B3AE16A41B; Fri, 21 Sep 2007 19:27:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id DBBF613C47E; Fri, 21 Sep 2007 19:27:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 210657262-1834499 for multiple; Fri, 21 Sep 2007 15:25:53 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l8LJRAHd063226; Fri, 21 Sep 2007 15:27:20 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrew Thompson Date: Fri, 21 Sep 2007 15:22:15 -0400 User-Agent: KMail/1.9.6 References: <200709150111.l8F1BQii070212@repoman.freebsd.org> <20070917161848.GB79417@elvis.mu.org> <20070917203208.GA9614@heff.fud.org.nz> In-Reply-To: <20070917203208.GA9614@heff.fud.org.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709211522.16194.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 21 Sep 2007 15:27:20 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4357/Fri Sep 21 05:55:46 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, Alfred Perlstein , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net ieee8023ad_lacp.c ieee8023ad_lacp.h if_lagg.c if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 19:27:31 -0000 On Monday 17 September 2007 04:32:08 pm Andrew Thompson wrote: > On Mon, Sep 17, 2007 at 09:18:48AM -0700, Alfred Perlstein wrote: > > * Andrew Thompson [070914 18:11] wrote: > > > thompsa 2007-09-15 01:11:26 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/net ieee8023ad_lacp.c ieee8023ad_lacp.h > > > if_lagg.c if_lagg.h > > > Log: > > > MFC > > > Change from a mutex to a read/write lock. This allows the tx port to be > > > selected simultaneously by multiple senders and transmit/receive is not > > > serialised between aggregated interfaces. > > > > Rad! :) > > And big thanks to you for MFCing it. Have you benchmarked this? Because rwlocks don't adaptively spin when a reader holds the lock, there are some cases where a mutex actually performs better than a rwlock. -- John Baldwin