From owner-cvs-all  Sun Sep  9  7:10:15 2001
Delivered-To: cvs-all@freebsd.org
Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51])
	by hub.freebsd.org (Postfix) with ESMTP
	id ACFC937B405; Sun,  9 Sep 2001 07:10:07 -0700 (PDT)
Received: by tao.org.uk (Postfix, from userid 100)
	id C37982F1; Sun,  9 Sep 2001 15:10:06 +0100 (BST)
Date: Sun, 9 Sep 2001 15:10:06 +0100
From: Josef Karthauser <joe@tao.org.uk>
To: Peter Wemm <peter@wemm.org>
Cc: Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl
Message-ID: <20010909151006.C69728@tao.org.uk>
References: <200109080211.f882BZt86733@freefall.freebsd.org> <20010908215254.D8BCD380A@overcee.netplex.com.au>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="yLVHuoLXiP9kZBkt"
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010908215254.D8BCD380A@overcee.netplex.com.au>; from peter@wemm.org on Sat, Sep 08, 2001 at 02:52:54PM -0700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


--yLVHuoLXiP9kZBkt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 08, 2001 at 02:52:54PM -0700, Peter Wemm wrote:
> Josef Karthauser wrote:
> > joe         2001/09/07 19:11:35 PDT
> >=20
> >   Modified files:
> >     .                    cfg.pm commit_prep.pl=20
> >   Log:
> >   Add code to unexpand $FreeBSD: xxxx $ (or whatever is defined in
> >   the config file as being our $IDHEADER$) upon commit.  This is useful
> >   to avoid a '+1 -1' delta against the version string.
>=20
> This is broken, it happens before the $Id$ spamming checks.  You only
> want this to be run after all the sanity checks are done.  Of course then
> you have to fix all the return's from the function. :-)

You mean that it happens before the spamming checks have had a
chance to complain?  I was so worried about making sure that this
worked for remote commits I forgot that it probably modifies the
file directly when committing locally.  I'll fix this.

> In fact, it should probably go after the &check_version() call, not
> inside check_version itself.

Except that it probably shouldn't touch files that are "excluded" right?
They're excluded for a reason.  I'll separate this out to make it
easier to handle.

Regards,
Joe

--yLVHuoLXiP9kZBkt
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjubeD0ACgkQXVIcjOaxUBY4jQCgp2WP59GuT5/dzjrHx1hxUudz
n8oAoJgu9yNaKv7yE/PgoXfNdIyoq3PB
=VftB
-----END PGP SIGNATURE-----

--yLVHuoLXiP9kZBkt--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message