From owner-freebsd-ports@FreeBSD.ORG Wed Oct 12 04:00:51 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4C211065673; Wed, 12 Oct 2011 04:00:51 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7568E8FC13; Wed, 12 Oct 2011 04:00:51 +0000 (UTC) Received: by iaky10 with SMTP id y10so391313iak.13 for ; Tue, 11 Oct 2011 21:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=fEpigrESls8C34r3IHTDgx0uo7kisqIVlxeh1ij1qrQ=; b=kCCZiaxI9qaORbC2MIAKOxoFIXaKTEG5pCyP6jo0Kyu7O2aD4MHHFBvzlOzTwUl6Ac icr33cbrL9e6eJ736QJAKClpUQeAz4+INXLiFNLacMTO4GvKkzjp00Nhno/dEvS+8lPG TIVOQ5afLZxUWqxzvpt6E3KZ6//OiAWrgh4J8= MIME-Version: 1.0 Received: by 10.231.69.80 with SMTP id y16mr11918596ibi.34.1318392050752; Tue, 11 Oct 2011 21:00:50 -0700 (PDT) Received: by 10.231.36.69 with HTTP; Tue, 11 Oct 2011 21:00:50 -0700 (PDT) In-Reply-To: <20111012033304.GA48367@nargothrond.kdm.org> References: <20111012033304.GA48367@nargothrond.kdm.org> Date: Tue, 11 Oct 2011 21:00:50 -0700 Message-ID: From: Kevin Oberman To: "Kenneth D. Merry" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: ports@freebsd.org Subject: Re: audio/cdparanoia broken on -CURRENT, and probably on 9.0 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2011 04:00:51 -0000 On Tue, Oct 11, 2011 at 8:33 PM, Kenneth D. Merry wrote: > On Tue, Oct 11, 2011 at 15:52:35 -0700, Kevin Oberman wrote: >> > On Fri, Oct 07, 2011 at 03:46:22 -0400, b. f. wrote: >> > > Just a note to say that recent changes on -CURRENT (r225950, meaning >> > > that it is probably broken on 9.0 after r226067) have broken >> > > audio/cdparanoia, and it should be fixed or marked as BROKEN there. = =A0I >> > > haven't filed a PR, or attempted to patch it yet -- I think that it >> > > would be worthwhile to look into moving to 10.2, which has a large >> > > number of improvements, although suffering from some Linuxisms. >> > >> > This will be easy to patch, using one of two methods: >> > >> > =A0- change struct scsi_sense_data to struct scsi_sense_data_fixed >> > or, better yet: >> > =A0- use scsi_extract_sense_len(), which will work for fixed or descri= ptor sense. >> >> Ken, >> >> OK. I have grepped through all of the cdparanoia sources and fine no >> instances of scsi_sense_data. Where in the heck do I find it so I can >> get this port built? 10.2 would be lovely, but I just need cdparanoia >> on 9-stable quickly and I fear that hte package will no longer work >> after r226067. > > There is no FreeBSD support in cdparanoia by default. =A0It is patched in= by > the ports system. > > Go into the directory for the port, do a 'make fetch' and then 'make patc= h'. > > Then go into cdparanoia-III-alpha9.8/interface and copy the attached file > on top of scsi_interface.c. > > I've checked that it compiles on a system running code before the change, > but I think that change should work for systems before or after the chang= e. > > Let me know whether it works for you. Thanks so much! Yes, the new scsi_interface.c compiled cleanly and cdparanoia built and installed. I am in the process of re-building all ports after I upgraded my system to 9-stable, so I really can't plug in my CD and try ripping aomething right now, but I'll try soonand let you know how it worked. Thanks again! --=20 R. Kevin Oberman, Network Engineer E-mail: kob6558@gmail.com